You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Roman Khachatryan (Jira)" <ji...@apache.org> on 2022/01/21 11:08:00 UTC
[jira] [Commented] (FLINK-25750) Performance regression on 20.01.2021 in globalWindow and stateBackend benchmarks
[ https://issues.apache.org/jira/browse/FLINK-25750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480006#comment-17480006 ]
Roman Khachatryan commented on FLINK-25750:
-------------------------------------------
The regression was most likely caused by 00856d068931a5988347b9bdbdf11bc700258fe1 (cc: [~dmvk]).
With this commit reverted, [results|http://codespeed.dak8s.net:8080/job/flink-benchmark-request/590/artifact/jmh-result.csv/*view*/] are the following
{code}
"Benchmark","Mode","Threads","Samples","Score","Score Error (99.9%)","Unit","Param: stateBackend"
"org.apache.flink.benchmark.MemoryStateBackendBenchmark.stateBackends","thrpt",1,30,4261.021704,49.701598,"ops/ms",MEMORY
"org.apache.flink.benchmark.MemoryStateBackendBenchmark.stateBackends","thrpt",1,30,4222.048683,74.720845,"ops/ms",FS
{code}
vs
with this commit included (master):
{code}
"Benchmark","Mode","Threads","Samples","Score","Score Error (99.9%)","Unit","Param: stateBackend"
"org.apache.flink.benchmark.MemoryStateBackendBenchmark.stateBackends","thrpt",1,30,4149.741549,57.208827,"ops/ms",MEMORY
"org.apache.flink.benchmark.MemoryStateBackendBenchmark.stateBackends","thrpt",1,30,4133.397272,98.646255,"ops/ms",FS
{code}
The change adds cloning the graph on job submission which explains the numbers above.
As decrease is not related to actual job performance, I'm going to close the issue as not a bug.
> Performance regression on 20.01.2021 in globalWindow and stateBackend benchmarks
> --------------------------------------------------------------------------------
>
> Key: FLINK-25750
> URL: https://issues.apache.org/jira/browse/FLINK-25750
> Project: Flink
> Issue Type: Bug
> Components: Benchmarks, Runtime / State Backends
> Affects Versions: 1.15.0
> Reporter: Roman Khachatryan
> Assignee: Roman Khachatryan
> Priority: Critical
> Fix For: 1.15.0
>
>
> http://codespeed.dak8s.net:8000/timeline/#/?exe=1,3&ben=globalWindow&env=2&revs=200&equid=off&quarts=on&extr=on
> http://codespeed.dak8s.net:8000/timeline/#/?exe=1,3&ben=stateBackends.FS&env=2&revs=200&equid=off&quarts=on&extr=on
> http://codespeed.dak8s.net:8000/timeline/#/?exe=1,3&ben=stateBackends.FS&env=2&revs=200&equid=off&quarts=on&extr=on
--
This message was sent by Atlassian Jira
(v8.20.1#820001)