You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/06/14 06:57:00 UTC

[jira] [Commented] (FLINK-9579) Remove unnecessary clear with cep elementQueue

    [ https://issues.apache.org/jira/browse/FLINK-9579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512048#comment-16512048 ] 

ASF GitHub Bot commented on FLINK-9579:
---------------------------------------

GitHub user Aitozi opened a pull request:

    https://github.com/apache/flink/pull/6162

    [FLINK-9579][CEP]Remove unneeded clear on elementQueueState

    ## What is the purpose of the change
    
    Remove unneeded clear on elementQueueState， when soretedTimestamp is empty, the elements in elementQueueState are all removed, so don't need to clear again to waste time on RocksDB operation.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Aitozi/flink remove-clear

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6162.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6162
    
----
commit 62a1a506cf8dab263a247d81fa7092eaa0743624
Author: minwenjun <mi...@...>
Date:   2018-06-14T06:20:42Z

    [FLINK-9579][CEP]Remove unneeded clear on elementQueueState

----


> Remove unnecessary clear with cep elementQueue
> ----------------------------------------------
>
>                 Key: FLINK-9579
>                 URL: https://issues.apache.org/jira/browse/FLINK-9579
>             Project: Flink
>          Issue Type: Improvement
>          Components: CEP
>    Affects Versions: 1.5.0
>            Reporter: aitozi
>            Assignee: aitozi
>            Priority: Major
>
> when deal with eventtime, the elementQueueState is cleared when sortedTimestamps isEmpty, but I think this operation is not needed because the elements in elementQueueState are all removed if the sortedTimestamps isEmpty, and do not need to clear again to spend time on rocksdb operation? what's your idea [~dawidwys]?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)