You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/03 08:54:47 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #11250: Strict type check for all hooks in amazon

kaxil commented on a change in pull request #11250:
URL: https://github.com/apache/airflow/pull/11250#discussion_r499130054



##########
File path: airflow/providers/amazon/aws/hooks/sns.py
##########
@@ -52,7 +53,7 @@ class AwsSnsHook(AwsBaseHook):
     def __init__(self, *args, **kwargs):
         super().__init__(client_type='sns', *args, **kwargs)
 
-    def publish_to_target(self, target_arn, message, subject=None, message_attributes=None):
+    def publish_to_target(self, target_arn, message, subject=None, message_attributes: Optional[dict] = None):

Review comment:
       Can you add TypeHints to `target_arn`, `message` and `subject` too please




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org