[GitHub] [tvm] areusch commented on pull request #10576: [ci] Clean up Jenkinsfile

[GitBox <gi...@apache.org>]

areusch commented on pull request #10576:
URL: https://github.com/apache/tvm/pull/10576#issuecomment-1068566378


   i think i still prefer the templated approach here, to be honest. while i think that logic like this eases high-level comprehension, it adds another layer of abstraction over what Jenkins is actually doing, so it makes it harder to debug problems:
   ```
       if (args.condition) {
         node(args.node_type) {
           ws(per_exec_ws(args.ws_name)) {
             timeout(time: max_time, unit: 'MINUTES') {
               init_git()
               if (args.junit) {
                 try {
                   args.script()
                 } finally {
                   junit 'build/pytest-results/*.xml'
                 }
               } else {
                 args.script()
               }
             }
           }
         }
       } else {
         Utils.markStageSkippedForConditional(args.name)
       }
     }
   }
   ```
   
   perhaps we could reconsider this as a templated approach once #10425 lands?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org