You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/03/01 18:09:27 UTC

[GitHub] surekhasaharan commented on a change in pull request #7176: Fix two SeekableStream serde issues.

surekhasaharan commented on a change in pull request #7176: Fix two SeekableStream serde issues.
URL: https://github.com/apache/incubator-druid/pull/7176#discussion_r261698310
 
 

 ##########
 File path: extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaIndexTaskModule.java
 ##########
 @@ -44,6 +44,7 @@
                 new NamedType(KafkaIndexTask.class, "index_kafka"),
                 new NamedType(KafkaDataSourceMetadata.class, "kafka"),
                 new NamedType(KafkaIndexTaskIOConfig.class, "kafka"),
+                new NamedType(KafkaIndexTaskTuningConfig.class, "KafkaTuningConfig"),
 
 Review comment:
   suggest to change the _name_ argument to "kafka_tuning_config" instead of "KafkaTuningConfig", to be consistent.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org