You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Geoff Callender (JIRA)" <de...@tapestry.apache.org> on 2008/03/09 02:37:46 UTC

[jira] Created: (TAPESTRY-2249) Add a "hidden fields" parameter to BeanEditor and BeanEditForm

Add a "hidden fields" parameter to BeanEditor and BeanEditForm
--------------------------------------------------------------

                 Key: TAPESTRY-2249
                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2249
             Project: Tapestry
          Issue Type: Improvement
          Components: tapestry-core
    Affects Versions: 5.0.11
            Reporter: Geoff Callender


A "hidden fields" parameter would allow code like this:

<t:beaneditform t:id="form" object="person" submitLabel="Save" hidden="version"/>

instead of this:

<t:beaneditform t:id="form" object="person" submitLabel="Save">
	<!-- Include version in the form to prevent it being updated/refreshed in onActivate(), which would defeat optimistic locking. -->
	<t:parameter name="version">
			<t:hidden t:id="version" value="person.version"/>
	</t:parameter>
</t:beaneditform>

Please note this is not the same as using remove, eg:

<t:beaneditform t:id="form" object="person" submitLabel="Save" remove="version"/>

which in this example would defeat optimistic locking because version's value would no longer make the round-trip to the client.

In case it helps, here's what onActivate() might looks like in this example:

	private Long _personId;

	@Persist("flash")
	private Person _person;

	void onActivate(Long id) throws Exception {
		_personId = id;

		if (_person == null) {
			_person = getPersonService().findPerson(_personId);

			if (_person == null) {
				throw new Exception("Person " + _personId + " does not exist.");
			}
		}
	}



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAPESTRY-2249) Add a "hidden fields" parameter to BeanEditor and BeanEditForm

Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAPESTRY-2249:
-------------------------------------------

    Fix Version/s: 5.1

> Add a "hidden fields" parameter to BeanEditor and BeanEditForm
> --------------------------------------------------------------
>
>                 Key: TAPESTRY-2249
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2249
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.0.11
>            Reporter: Geoff Callender
>            Priority: Minor
>             Fix For: 5.1
>
>
> A "hidden fields" parameter would allow code like this:
> <t:beaneditform t:id="form" object="person" submitLabel="Save" hidden="version"/>
> instead of this:
> <t:beaneditform t:id="form" object="person" submitLabel="Save">
> 	<!-- Include version in the form to prevent it being updated/refreshed in onActivate(), which would defeat optimistic locking. -->
> 	<t:parameter name="version">
> 			<t:hidden t:id="version" value="person.version"/>
> 	</t:parameter>
> </t:beaneditform>
> Please note this is not the same as using remove, eg:
> <t:beaneditform t:id="form" object="person" submitLabel="Save" remove="version"/>
> which in this example would defeat optimistic locking because version's value would no longer make the round-trip to the client.
> In case it helps, here's what onActivate() might looks like in this example:
> 	private Long _personId;
> 	@Persist("flash")
> 	private Person _person;
> 	void onActivate(Long id) throws Exception {
> 		_personId = id;
> 		if (_person == null) {
> 			_person = getPersonService().findPerson(_personId);
> 			if (_person == null) {
> 				throw new Exception("Person " + _personId + " does not exist.");
> 			}
> 		}
> 	}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAPESTRY-2249) Add a "hidden fields" parameter to BeanEditor and BeanEditForm

Posted by "Davor Hrg (JIRA)" <de...@tapestry.apache.org>.
    [ https://issues.apache.org/jira/browse/TAPESTRY-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576806#action_12576806 ] 

Davor Hrg commented on TAPESTRY-2249:
-------------------------------------

This could also be solved by using @DataType("hidden")

https://issues.apache.org/jira/browse/TAPESTRY-2012

and making "hidden" bean block contribution



> Add a "hidden fields" parameter to BeanEditor and BeanEditForm
> --------------------------------------------------------------
>
>                 Key: TAPESTRY-2249
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2249
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.0.11
>            Reporter: Geoff Callender
>            Priority: Minor
>
> A "hidden fields" parameter would allow code like this:
> <t:beaneditform t:id="form" object="person" submitLabel="Save" hidden="version"/>
> instead of this:
> <t:beaneditform t:id="form" object="person" submitLabel="Save">
> 	<!-- Include version in the form to prevent it being updated/refreshed in onActivate(), which would defeat optimistic locking. -->
> 	<t:parameter name="version">
> 			<t:hidden t:id="version" value="person.version"/>
> 	</t:parameter>
> </t:beaneditform>
> Please note this is not the same as using remove, eg:
> <t:beaneditform t:id="form" object="person" submitLabel="Save" remove="version"/>
> which in this example would defeat optimistic locking because version's value would no longer make the round-trip to the client.
> In case it helps, here's what onActivate() might looks like in this example:
> 	private Long _personId;
> 	@Persist("flash")
> 	private Person _person;
> 	void onActivate(Long id) throws Exception {
> 		_personId = id;
> 		if (_person == null) {
> 			_person = getPersonService().findPerson(_personId);
> 			if (_person == null) {
> 				throw new Exception("Person " + _personId + " does not exist.");
> 			}
> 		}
> 	}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAPESTRY-2249) Add a "hidden fields" parameter to BeanEditor and BeanEditForm

Posted by "Geoff Callender (JIRA)" <de...@tapestry.apache.org>.
    [ https://issues.apache.org/jira/browse/TAPESTRY-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576972#action_12576972 ] 

Geoff Callender commented on TAPESTRY-2249:
-------------------------------------------

I don't particularly want to put @DataType("hidden") on my domain entities (such as Person in the example), so I would vote to enable both approaches.

> Add a "hidden fields" parameter to BeanEditor and BeanEditForm
> --------------------------------------------------------------
>
>                 Key: TAPESTRY-2249
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2249
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.0.11
>            Reporter: Geoff Callender
>            Priority: Minor
>
> A "hidden fields" parameter would allow code like this:
> <t:beaneditform t:id="form" object="person" submitLabel="Save" hidden="version"/>
> instead of this:
> <t:beaneditform t:id="form" object="person" submitLabel="Save">
> 	<!-- Include version in the form to prevent it being updated/refreshed in onActivate(), which would defeat optimistic locking. -->
> 	<t:parameter name="version">
> 			<t:hidden t:id="version" value="person.version"/>
> 	</t:parameter>
> </t:beaneditform>
> Please note this is not the same as using remove, eg:
> <t:beaneditform t:id="form" object="person" submitLabel="Save" remove="version"/>
> which in this example would defeat optimistic locking because version's value would no longer make the round-trip to the client.
> In case it helps, here's what onActivate() might looks like in this example:
> 	private Long _personId;
> 	@Persist("flash")
> 	private Person _person;
> 	void onActivate(Long id) throws Exception {
> 		_personId = id;
> 		if (_person == null) {
> 			_person = getPersonService().findPerson(_personId);
> 			if (_person == null) {
> 				throw new Exception("Person " + _personId + " does not exist.");
> 			}
> 		}
> 	}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAP5-94) Add a "hidden fields" parameter to BeanEditor and BeanEditForm

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-94?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAP5-94:
-------------------------------------

    Issue Type: New Feature  (was: Bug)

> Add a "hidden fields" parameter to BeanEditor and BeanEditForm
> --------------------------------------------------------------
>
>                 Key: TAP5-94
>                 URL: https://issues.apache.org/jira/browse/TAP5-94
>             Project: Tapestry 5
>          Issue Type: New Feature
>    Affects Versions: 5.0.15
>            Reporter: Geoff Callender
>            Priority: Minor
>
> A "hidden fields" parameter would allow code like this:
> <t:beaneditform t:id="form" object="person" submitLabel="Save" hidden="version"/>
> instead of this:
> <t:beaneditform t:id="form" object="person" submitLabel="Save">
> 	<!-- Include version in the form to prevent it being updated/refreshed in onActivate(), which would defeat optimistic locking. -->
> 	<t:parameter name="version">
> 			<t:hidden t:id="version" value="person.version"/>
> 	</t:parameter>
> </t:beaneditform>
> Please note this is not the same as using remove, eg:
> <t:beaneditform t:id="form" object="person" submitLabel="Save" remove="version"/>
> which in this example would defeat optimistic locking because version's value would no longer make the round-trip to the client.
> In case it helps, here's what onActivate() might looks like in this example:
> 	private Long _personId;
> 	@Persist("flash")
> 	private Person _person;
> 	void onActivate(Long id) throws Exception {
> 		_personId = id;
> 		if (_person == null) {
> 			_person = getPersonService().findPerson(_personId);
> 			if (_person == null) {
> 				throw new Exception("Person " + _personId + " does not exist.");
> 			}
> 		}
> 	}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAPESTRY-2249) Add a "hidden fields" parameter to BeanEditor and BeanEditForm

Posted by "Geoff Callender (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Geoff Callender updated TAPESTRY-2249:
--------------------------------------

    Priority: Minor  (was: Major)

> Add a "hidden fields" parameter to BeanEditor and BeanEditForm
> --------------------------------------------------------------
>
>                 Key: TAPESTRY-2249
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2249
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.0.11
>            Reporter: Geoff Callender
>            Priority: Minor
>
> A "hidden fields" parameter would allow code like this:
> <t:beaneditform t:id="form" object="person" submitLabel="Save" hidden="version"/>
> instead of this:
> <t:beaneditform t:id="form" object="person" submitLabel="Save">
> 	<!-- Include version in the form to prevent it being updated/refreshed in onActivate(), which would defeat optimistic locking. -->
> 	<t:parameter name="version">
> 			<t:hidden t:id="version" value="person.version"/>
> 	</t:parameter>
> </t:beaneditform>
> Please note this is not the same as using remove, eg:
> <t:beaneditform t:id="form" object="person" submitLabel="Save" remove="version"/>
> which in this example would defeat optimistic locking because version's value would no longer make the round-trip to the client.
> In case it helps, here's what onActivate() might looks like in this example:
> 	private Long _personId;
> 	@Persist("flash")
> 	private Person _person;
> 	void onActivate(Long id) throws Exception {
> 		_personId = id;
> 		if (_person == null) {
> 			_person = getPersonService().findPerson(_personId);
> 			if (_person == null) {
> 				throw new Exception("Person " + _personId + " does not exist.");
> 			}
> 		}
> 	}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org