You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2016/03/08 19:51:16 UTC
[GitHub] couchdb-fauxton pull request: Minor text/btn changes
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/661
Minor text/btn changes
This makes a few further additions to buttons / text / styles,
as per Justin's recommendations.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton minor-btn-text-tweaks
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/661.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #661
----
commit 37188df6ce9dd5c7dbcf7da2b91be57b8ae96c20
Author: Ben Keen <be...@gmail.com>
Date: 2016-03-08T18:50:02Z
Minor text/btn changes
This makes a few further additions to buttons / text / styles,
as per Justin's recommendations.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Minor text/btn changes
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/661#issuecomment-195324240
good work! +1 after removing the dead class
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Minor text/btn changes
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/661#discussion_r55817838
--- Diff: app/addons/documents/doc-editor/components.react.jsx ---
@@ -143,12 +143,14 @@ define([
},
render: function () {
+ var saveButtonLabel = (this.props.isNewDoc) ? 'Create Document' : 'Save Changes';
--- End diff --
minor: no parens needed, but feel free to leave it like it is, no hard opinions here from my side
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Minor text/btn changes
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/661
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Minor text/btn changes
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/661#issuecomment-211577372
Merged as bd7205f45c2c2448da7e8e06f743f2d0444177f9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Minor text/btn changes
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/661#discussion_r55817726
--- Diff: app/addons/fauxton/components.react.jsx ---
@@ -377,6 +378,8 @@ function (app, FauxtonAPI, React, ReactDOM, ZeroClipboard, ReactBootstrap) {
},
render: function () {
+ var btnClasses = 'btn js-btn-success ' + this.props.buttonClass;
--- End diff --
`js-btn-success` i think this class is unused
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---