You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Michael Gerhards (JIRA)" <ji...@apache.org> on 2018/12/06 08:57:00 UTC
[jira] [Commented] (WICKET-6569) LambdaModel.of overload is
ambiguous
[ https://issues.apache.org/jira/browse/WICKET-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711151#comment-16711151 ]
Michael Gerhards commented on WICKET-6569:
------------------------------------------
Would it make sence to
1) copy the affected ".of(...)" methods with a different method name, so that the methods are no longer overloaded and
2) mark the affected ".of(...)" methods as deprecated but without removal. Similar to "optional.get()" method is replaced by "optional.orElseThrow()" method.
This would solve the problem without having an API break since you just add new methods.
> LambdaModel.of overload is ambiguous
> ------------------------------------
>
> Key: WICKET-6569
> URL: https://issues.apache.org/jira/browse/WICKET-6569
> Project: Wicket
> Issue Type: Wish
> Components: wicket
> Affects Versions: 8.0.0
> Reporter: Michael Gerhards
> Priority: Minor
> Attachments: myproject.zip
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> a method call of
> LambdaModel.of(this::getModelObject, this::setModelObject)
> refers to
> public static <X, R> IModel<R> of(IModel<X> target, SerializableFunction<X, R> getter)
> but should be
> public static <R> IModel<R> of(SerializableSupplier<R> getter, SerializableConsumer<R> setter)
> The problem is that IModel and SerializableSupplier have functionally the same interface:
> T getObject(); vs. T get();
>
> Background:
> The child component should share its default model object with its parent component's default model object. So if setDefaultModelObject is called on the parent component than the child component should also refer to the new value (and with versa).
>
> Workaround:
> public Parent(String wicektId, IModel<Role> roleModel) {
> IModel<Role> childRoleModel = new IModel<Role>() {
> @Override
> public Role getObject()
> { return Parent.this.getModelObject(); }
> @Override
> public void setObject(Role object)
> { Parent.this.setModelObject(object); }
> };
> add(new Child("child", childRoleModel));
> }
>
> Solution:
> The problem only exists because .of Method is overloaded. If both methods would have different names (or be in different classes) than the compiler would be fine.
>
> Please see attached files
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)