You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/12/14 11:23:18 UTC

[GitHub] rafaelweingartner commented on a change in pull request #3095: Prevent corner case for infinite PrepareForMaintenance

rafaelweingartner commented on a change in pull request #3095: Prevent corner case for infinite PrepareForMaintenance
URL: https://github.com/apache/cloudstack/pull/3095#discussion_r241722610
 
 

 ##########
 File path: server/src/com/cloud/resource/ResourceManagerImpl.java
 ##########
 @@ -1350,7 +1364,23 @@ protected boolean isHostInMaintenance(HostVO host, List<VMInstanceVO> runningVms
             return CollectionUtils.isEmpty(failedMigrations) ?
                     setHostIntoMaintenance(host) :
                     setHostIntoErrorInMaintenance(host, failedMigrations);
+        } else if (retryHostMaintenance.containsKey(host.getId())) {
 
 Review comment:
   you do not need the else here. I mean, the other if body will always return. Therefore, you can simply follow with an IF. This will change a bit the formatting.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services