You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jarohen (via GitHub)" <gi...@apache.org> on 2024/03/26 23:45:14 UTC
[PR] GH-40773: [Java] add `DENSEUNION` case to StructWriters, resolves #40773 [arrow]
jarohen opened a new pull request, #40809:
URL: https://github.com/apache/arrow/pull/40809
### What changes are included in this PR?
Adding a `DENSEUNION` case to the `StructWriters` template so that one can create StructVectors with a DenseUnionVector child.
### Are these changes tested?
Yes
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40773: [Java] add `DENSEUNION` case to StructWriters, resolves #40773 [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #40809:
URL: https://github.com/apache/arrow/pull/40809#issuecomment-2024451025
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 515c61dd617e65c01a6e40e570487ad4ae9f151c.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/23185262690) has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40773: [Java] add `DENSEUNION` case to StructWriters, resolves #40773 [arrow]
Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin commented on code in PR #40809:
URL: https://github.com/apache/arrow/pull/40809#discussion_r1541384425
##########
java/vector/src/test/java/org/apache/arrow/vector/TestValueVector.java:
##########
@@ -17,6 +17,7 @@
package org.apache.arrow.vector;
+import static java.util.Collections.emptyList;
Review Comment:
+1 for non-static
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40773: [Java] add `DENSEUNION` case to StructWriters, resolves #40773 [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on code in PR #40809:
URL: https://github.com/apache/arrow/pull/40809#discussion_r1540344495
##########
java/vector/src/test/java/org/apache/arrow/vector/TestValueVector.java:
##########
@@ -17,6 +17,7 @@
package org.apache.arrow.vector;
+import static java.util.Collections.emptyList;
Review Comment:
nit: would it be better to use a non-static import and use `emptyList`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40773: [Java] add `DENSEUNION` case to StructWriters, resolves #40773 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40809:
URL: https://github.com/apache/arrow/pull/40809#issuecomment-2021658952
:warning: GitHub issue #40773 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40773: [Java] add `DENSEUNION` case to StructWriters, resolves #40773 [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #40809:
URL: https://github.com/apache/arrow/pull/40809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40773: [Java] add `DENSEUNION` case to StructWriters, resolves #40773 [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #40809:
URL: https://github.com/apache/arrow/pull/40809#issuecomment-2023645002
Integration failure looks to be a flake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40773: [Java] add `DENSEUNION` case to StructWriters, resolves #40773 [arrow]
Posted by "jarohen (via GitHub)" <gi...@apache.org>.
jarohen commented on code in PR #40809:
URL: https://github.com/apache/arrow/pull/40809#discussion_r1540847768
##########
java/vector/src/test/java/org/apache/arrow/vector/TestValueVector.java:
##########
@@ -17,6 +17,7 @@
package org.apache.arrow.vector;
+import static java.util.Collections.emptyList;
Review Comment:
happy to if that's the convention, yep :slightly_smiling_face:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40773: [Java] add `DENSEUNION` case to StructWriters, resolves #40773 [arrow]
Posted by "jarohen (via GitHub)" <gi...@apache.org>.
jarohen commented on code in PR #40809:
URL: https://github.com/apache/arrow/pull/40809#discussion_r1541597978
##########
java/vector/src/test/java/org/apache/arrow/vector/TestValueVector.java:
##########
@@ -17,6 +17,7 @@
package org.apache.arrow.vector;
+import static java.util.Collections.emptyList;
Review Comment:
updated :slightly_smiling_face:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org