[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #715: nimble/btshell: Add support for toggling reporting

[GitBox <gi...@apache.org>]

andrzej-kaczmarek commented on a change in pull request #715: nimble/btshell: Add support for toggling reporting
URL: https://github.com/apache/mynewt-nimble/pull/715#discussion_r362550990
 
 

 ##########
 File path: apps/btshell/src/cmd.c
 ##########
 @@ -3861,6 +3894,18 @@ static const struct shell_cmd_help sync_transfer_help = {
     .usage = NULL,
     .params = sync_transfer_params,
 };
+
+static const struct shell_param sync_reporting_params[] = {
+    {"sync_handle", "sync handle, usage: =[UINT16], default: 0"},
+    {"toggle_reporting", "toggle reporting, usage: =[0-1], default: 0"},
+    {NULL, NULL}
+};
+
+static const struct shell_cmd_help sync_reporting_help = {
+   .summary = "start periodic advertising sync reporting",
 
 Review comment:
   better describe it as "configure" instead of "start"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services