You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2016/06/06 02:46:03 UTC
[GitHub] incubator-zeppelin pull request #966: [ZEPPELIN-958] Support syntax highligh...
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/966
[ZEPPELIN-958] Support syntax highlight for python and r interpreter
### What is this PR for?
Support syntax highlight for python and r interpreter
### What type of PR is it?
Bug Fix
### What is the Jira issue?
[ZEPPELIN-958](https://issues.apache.org/jira/browse/ZEPPELIN-958)
### Screenshots (if appropriate)
**Before**
<img width="412" alt="screen shot 2016-06-05 at 7 43 08 pm" src="https://cloud.githubusercontent.com/assets/8503346/15810667/c96e85c0-2b55-11e6-9539-d3cc9a0df35f.png">
**After**
<img width="412" alt="screen shot 2016-06-05 at 7 42 55 pm" src="https://cloud.githubusercontent.com/assets/8503346/15810670/cd7960fe-2b55-11e6-8145-50517eaf2195.png">
**Before**
<img width="647" alt="screen shot 2016-06-05 at 7 30 53 pm" src="https://cloud.githubusercontent.com/assets/8503346/15810554/c6e49ec6-2b54-11e6-8b8b-a327dd76d437.png">
**After**
<img width="604" alt="screen shot 2016-06-05 at 7 30 31 pm" src="https://cloud.githubusercontent.com/assets/8503346/15810551/bf48cfc0-2b54-11e6-9ad1-bc16596074ee.png">
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/minahlee/incubator-zeppelin ZEPPELIN-958
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/966.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #966
----
commit 9821f94e94a6e15520a125966ee6f990945714f8
Author: Mina Lee <mi...@nflabs.com>
Date: 2016-06-06T02:33:00Z
Support syntax hightlight for python and r interpreter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #966: [ZEPPELIN-958] Support syntax highlight for p...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/966
Looks great to me, let's merge as a short term solution.
And yes, as @felixcheung mentioned - in a mid\long term, it would be great for interpreter to encapsulate this knowledge!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #966: [ZEPPELIN-958] Support syntax highlight for p...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/966
LGTM
btw, this is getting fragile - would be great if interpreter can have an extension mechanism to control what it is mapping to on the js side.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #966: [ZEPPELIN-958] Support syntax highlight for p...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/966
Merging if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #966: [ZEPPELIN-958] Support syntax highlight for p...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/966
@felixcheung Could you please tell me your idea in details? Basically I agree with you, but I'm not good at frontend, I don't know whether the feature can be adopted dynamically or not. If it's possible, you could that feature into Interpreter scope. It seems nice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #966: [ZEPPELIN-958] Support syntax highlight for p...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/966
BTW, this PR looks good to me. We can discuss @felixcheung's issue after merging this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---