You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "quantranhong1999 (via GitHub)" <gi...@apache.org> on 2026/07/13 09:29:30 UTC

[PR] JAMES-4210 [POP3] Pass command shall rely on PlainSaslMechanism logic [james-project]

quantranhong1999 opened a new pull request, #3089:
URL: https://github.com/apache/james-project/pull/3089

   Similar to what we did with IMAP's LOGIN command: rely on `PlainSaslMechanism`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

Re: [PR] JAMES-4210 [POP3] Pass command shall rely on PlainSaslMechanism logic [james-project]

Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 commented on code in PR #3089:
URL: https://github.com/apache/james-project/pull/3089#discussion_r3587207313


##########
server/protocols/protocols-pop3/src/main/java/org/apache/james/pop3server/core/PassCmdHandler.java:
##########
@@ -59,7 +62,7 @@
  */
 public class PassCmdHandler extends AbstractPassCmdHandler  {
     private static final Logger LOGGER = LoggerFactory.getLogger(PassCmdHandler.class);
-    private static final PlainSaslMechanism PLAIN_SASL_MECHANISM = new PlainSaslMechanism(true, false);
+    private static final PlainSaslMechanism PLAIN_SASL_MECHANISM = new PlainSaslMechanism(ENABLED, !REQUIRE_SSL);

Review Comment:
   > Make it true (secure) by default
   
   Currently, POP3 PASS command always accepts clear-text authentication. POP3 does not have the `auth.requireSSL` option yet. `!REQUIRE_SSL` therefore keeps the existing behavior.
   
   I plan to add `auth.requireSSL` (and other related authentication configs like `auth.saslMechanisms`) in the upcoming [Implement RFC 5034 SASL for POP3](https://github.com/linagora/james-project/issues/5574) work.
   
   And then we can make the POP3 PASS command respect the `auth.requireSSL` option (default to `true`).
   
   Is that OK to you?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

Re: [PR] JAMES-4210 [POP3] Pass command shall rely on PlainSaslMechanism logic [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #3089:
URL: https://github.com/apache/james-project/pull/3089#discussion_r3586310281


##########
server/protocols/protocols-pop3/src/main/java/org/apache/james/pop3server/core/PassCmdHandler.java:
##########
@@ -59,7 +62,7 @@
  */
 public class PassCmdHandler extends AbstractPassCmdHandler  {
     private static final Logger LOGGER = LoggerFactory.getLogger(PassCmdHandler.class);
-    private static final PlainSaslMechanism PLAIN_SASL_MECHANISM = new PlainSaslMechanism(true, false);
+    private static final PlainSaslMechanism PLAIN_SASL_MECHANISM = new PlainSaslMechanism(ENABLED, !REQUIRE_SSL);

Review Comment:
   While we are at it
   
   This `!REQUIRE_SSL` is uggly
   
   I'd prefer we:
    - Make it `true` (secure) by default
    - Use the same config path than SMTP to make it insecure



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

Re: [PR] JAMES-4210 [POP3] Pass command shall rely on PlainSaslMechanism logic [james-project]

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael merged PR #3089:
URL: https://github.com/apache/james-project/pull/3089


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

Re: [PR] JAMES-4210 [POP3] Pass command shall rely on PlainSaslMechanism logic [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #3089:
URL: https://github.com/apache/james-project/pull/3089#discussion_r3587485282


##########
server/protocols/protocols-pop3/src/main/java/org/apache/james/pop3server/core/PassCmdHandler.java:
##########
@@ -59,7 +62,7 @@
  */
 public class PassCmdHandler extends AbstractPassCmdHandler  {
     private static final Logger LOGGER = LoggerFactory.getLogger(PassCmdHandler.class);
-    private static final PlainSaslMechanism PLAIN_SASL_MECHANISM = new PlainSaslMechanism(true, false);
+    private static final PlainSaslMechanism PLAIN_SASL_MECHANISM = new PlainSaslMechanism(ENABLED, !REQUIRE_SSL);

Review Comment:
   That's OK ;-)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

Re: [PR] JAMES-4210 [POP3] Pass command shall rely on PlainSaslMechanism logic [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #3089:
URL: https://github.com/apache/james-project/pull/3089#discussion_r3584996287


##########
server/protocols/protocols-pop3/src/main/java/org/apache/james/pop3server/core/PassCmdHandler.java:
##########
@@ -55,15 +59,18 @@
  */
 public class PassCmdHandler extends AbstractPassCmdHandler  {
     private static final Logger LOGGER = LoggerFactory.getLogger(PassCmdHandler.class);
+    private static final PlainSaslMechanism PLAIN_SASL_MECHANISM = new PlainSaslMechanism(true, false);

Review Comment:
   What does `(true, false)` means?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org