You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Jonathan Coveney (Created) (JIRA)" <ji...@apache.org> on 2012/03/16 05:17:56 UTC

[jira] [Created] (PIG-2598) Change source structure for sources in other languages

Change source structure for sources in other languages
------------------------------------------------------

                 Key: PIG-2598
                 URL: https://issues.apache.org/jira/browse/PIG-2598
             Project: Pig
          Issue Type: Improvement
            Reporter: Jonathan Coveney
             Fix For: 0.11


Currently, the source structure only supports java (ie src/org/apache/etc). The JRuby script support will necessitate a JRuby file as source, and there is currently no home for it. There are a couple options:

1) the cleanest is moving to src/main/java, src/main/ruby, etc. The issue with this is it would require rebasing all patches. That's pretty big...but as Pig grows, may be necessary (this might be a good chance to fix the formatting and spacing of old files!)
2) add a src-jruby/ directory
3) add a src/jruby/ directory

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (PIG-2598) Change source structure for sources in other languages

Posted by "Alan Gates (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231416#comment-13231416 ] 

Alan Gates commented on PIG-2598:
---------------------------------

As said on the dev list, I vote for options 2 or 3 until there is a clear benefit to option 1.  I don't know of any benefit to 1 beyond maven conformance.  Conforming to maven isn't important until we use maven.
                
> Change source structure for sources in other languages
> ------------------------------------------------------
>
>                 Key: PIG-2598
>                 URL: https://issues.apache.org/jira/browse/PIG-2598
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Jonathan Coveney
>             Fix For: 0.11
>
>
> Currently, the source structure only supports java (ie src/org/apache/etc). The JRuby script support will necessitate a JRuby file as source, and there is currently no home for it. There are a couple options:
> 1) the cleanest is moving to src/main/java, src/main/ruby, etc. The issue with this is it would require rebasing all patches. That's pretty big...but as Pig grows, may be necessary (this might be a good chance to fix the formatting and spacing of old files!)
> 2) add a src-jruby/ directory
> 3) add a src/jruby/ directory

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (PIG-2598) Change source structure for sources in other languages

Posted by "Daniel Dai (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231588#comment-13231588 ] 

Daniel Dai commented on PIG-2598:
---------------------------------

Either 2 or 3 is fine. I like 3 slightly better cuz I saw this layout in other projects, such as jruby itself.
                
> Change source structure for sources in other languages
> ------------------------------------------------------
>
>                 Key: PIG-2598
>                 URL: https://issues.apache.org/jira/browse/PIG-2598
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Jonathan Coveney
>             Fix For: 0.11
>
>
> Currently, the source structure only supports java (ie src/org/apache/etc). The JRuby script support will necessitate a JRuby file as source, and there is currently no home for it. There are a couple options:
> 1) the cleanest is moving to src/main/java, src/main/ruby, etc. The issue with this is it would require rebasing all patches. That's pretty big...but as Pig grows, may be necessary (this might be a good chance to fix the formatting and spacing of old files!)
> 2) add a src-jruby/ directory
> 3) add a src/jruby/ directory

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (PIG-2598) Change source structure for sources in other languages

Posted by "Jonathan Coveney (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Coveney resolved PIG-2598.
-----------------------------------

      Resolution: Fixed
        Assignee: Jonathan Coveney
    Release Note: This was resolved as a part of PIG-2317
    
> Change source structure for sources in other languages
> ------------------------------------------------------
>
>                 Key: PIG-2598
>                 URL: https://issues.apache.org/jira/browse/PIG-2598
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Jonathan Coveney
>            Assignee: Jonathan Coveney
>             Fix For: 0.11
>
>
> Currently, the source structure only supports java (ie src/org/apache/etc). The JRuby script support will necessitate a JRuby file as source, and there is currently no home for it. There are a couple options:
> 1) the cleanest is moving to src/main/java, src/main/ruby, etc. The issue with this is it would require rebasing all patches. That's pretty big...but as Pig grows, may be necessary (this might be a good chance to fix the formatting and spacing of old files!)
> 2) add a src-jruby/ directory
> 3) add a src/jruby/ directory

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (PIG-2598) Change source structure for sources in other languages

Posted by "Jonathan Coveney (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Coveney reassigned PIG-2598:
-------------------------------------

    Assignee:     (was: Jonathan Coveney)
    
> Change source structure for sources in other languages
> ------------------------------------------------------
>
>                 Key: PIG-2598
>                 URL: https://issues.apache.org/jira/browse/PIG-2598
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Jonathan Coveney
>             Fix For: 0.11
>
>
> Currently, the source structure only supports java (ie src/org/apache/etc). The JRuby script support will necessitate a JRuby file as source, and there is currently no home for it. There are a couple options:
> 1) the cleanest is moving to src/main/java, src/main/ruby, etc. The issue with this is it would require rebasing all patches. That's pretty big...but as Pig grows, may be necessary (this might be a good chance to fix the formatting and spacing of old files!)
> 2) add a src-jruby/ directory
> 3) add a src/jruby/ directory

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (PIG-2598) Change source structure for sources in other languages

Posted by "Jonathan Coveney (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231591#comment-13231591 ] 

Jonathan Coveney commented on PIG-2598:
---------------------------------------

Alan suggested going with the maven form for ruby off the bat, and leaving the rest at bay, so I'm going to put my script in src/main/jruby and go from there. Sound ok?
                
> Change source structure for sources in other languages
> ------------------------------------------------------
>
>                 Key: PIG-2598
>                 URL: https://issues.apache.org/jira/browse/PIG-2598
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Jonathan Coveney
>             Fix For: 0.11
>
>
> Currently, the source structure only supports java (ie src/org/apache/etc). The JRuby script support will necessitate a JRuby file as source, and there is currently no home for it. There are a couple options:
> 1) the cleanest is moving to src/main/java, src/main/ruby, etc. The issue with this is it would require rebasing all patches. That's pretty big...but as Pig grows, may be necessary (this might be a good chance to fix the formatting and spacing of old files!)
> 2) add a src-jruby/ directory
> 3) add a src/jruby/ directory

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (PIG-2598) Change source structure for sources in other languages

Posted by "Daniel Dai (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231596#comment-13231596 ] 

Daniel Dai commented on PIG-2598:
---------------------------------

Sounds Ok.
                
> Change source structure for sources in other languages
> ------------------------------------------------------
>
>                 Key: PIG-2598
>                 URL: https://issues.apache.org/jira/browse/PIG-2598
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Jonathan Coveney
>             Fix For: 0.11
>
>
> Currently, the source structure only supports java (ie src/org/apache/etc). The JRuby script support will necessitate a JRuby file as source, and there is currently no home for it. There are a couple options:
> 1) the cleanest is moving to src/main/java, src/main/ruby, etc. The issue with this is it would require rebasing all patches. That's pretty big...but as Pig grows, may be necessary (this might be a good chance to fix the formatting and spacing of old files!)
> 2) add a src-jruby/ directory
> 3) add a src/jruby/ directory

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira