You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/04/10 19:10:00 UTC

[jira] [Commented] (PDFBOX-4187) Refactor LosslessFactory alpha

    [ https://issues.apache.org/jira/browse/PDFBOX-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432791#comment-16432791 ] 

ASF subversion and git services commented on PDFBOX-4187:
---------------------------------------------------------

Commit 1828848 from [~tilman] in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1828848 ]

PDFBOX-4187: refactor, use the alpha value from getRGB()

> Refactor LosslessFactory alpha
> ------------------------------
>
>                 Key: PDFBOX-4187
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4187
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: PDModel
>    Affects Versions: 2.0.9, 3.0.0 PDFBox
>            Reporter: Tilman Hausherr
>            Assignee: Tilman Hausherr
>            Priority: Minor
>             Fix For: 2.0.10, 3.0.0 PDFBox
>
>
> While looking into the code for PDFBOX-4184 I noticed that we try to get the alpha data in different ways, despite that it is available in the main method when {{image.getRGB()}} is called. So I'm refactoring all this; as a side effect, my 16 bit change in PDFBOX-4184 is no longer needed.
> I'll commit this in two steps; 1) changing the main method and remove the ones that are no longer being used; 2) split the main method in a gray and a color code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org