You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by br...@apache.org on 2003/09/23 04:53:57 UTC
cvs commit: jakarta-commons/net/src/test/org/apache/commons/net/telnet TelnetClientTest.java
brekke 2003/09/22 19:53:57
Modified: net project.xml
net/src/java/examples ExtendedNNTPOps.java
net/src/java/org/apache/commons/net/telnet
TelnetNotificationHandler.java
net/src/test/org/apache/commons/net/telnet
TelnetClientTest.java
Log:
Just some minor cleanups, removing unused imports and variables. Eclipse
was posing warnings about them, so it was easy to clean them up.
Revision Changes Path
1.30 +5 -6 jakarta-commons/net/project.xml
Index: project.xml
===================================================================
RCS file: /home/cvs/jakarta-commons/net/project.xml,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -r1.29 -r1.30
--- project.xml 9 May 2003 14:43:07 -0000 1.29
+++ project.xml 23 Sep 2003 02:53:56 -0000 1.30
@@ -143,16 +143,15 @@
</build>
<reports>
- <report>maven-tasklist-plugin</report>
<report>maven-changes-plugin</report>
- <report>maven-changelog-plugin</report>
- <report>maven-file-activity-plugin</report>
- <report>maven-developer-activity-plugin</report>
- <report>maven-javadoc-plugin</report>
- <report>maven-jxr-plugin</report>
+ <report>maven-tasklist-plugin</report>
<report>maven-junit-report-plugin</report>
<report>maven-jdepend-plugin</report>
+ <report>maven-jcoverage-plugin</report>
<report>maven-checkstyle-plugin</report>
+ <report>maven-statcvs-plugin</report>
+ <report>maven-javadoc-plugin</report>
+ <report>maven-jxr-plugin</report>
</reports>
</project>
1.2 +0 -3 jakarta-commons/net/src/java/examples/ExtendedNNTPOps.java
Index: ExtendedNNTPOps.java
===================================================================
RCS file: /home/cvs/jakarta-commons/net/src/java/examples/ExtendedNNTPOps.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- ExtendedNNTPOps.java 4 Sep 2003 20:32:43 -0000 1.1
+++ ExtendedNNTPOps.java 23 Sep 2003 02:53:56 -0000 1.2
@@ -145,8 +145,6 @@
{
ArrayList articles = new ArrayList();
Reader reader = null;
- String theMessage;
- char[] buffer = new char[128];
reader = (DotTerminatedMessageReader)
client.retrieveArticleInfo(lowArticleNumber, highArticleNumber);
@@ -181,7 +179,6 @@
String temp;
StringBuffer sb = null;
BufferedReader bufReader = new BufferedReader(reader);
- boolean endOfHeader = false;
sb = new StringBuffer();
try
1.2 +0 -7 jakarta-commons/net/src/java/org/apache/commons/net/telnet/TelnetNotificationHandler.java
Index: TelnetNotificationHandler.java
===================================================================
RCS file: /home/cvs/jakarta-commons/net/src/java/org/apache/commons/net/telnet/TelnetNotificationHandler.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- TelnetNotificationHandler.java 10 Aug 2003 09:20:38 -0000 1.1
+++ TelnetNotificationHandler.java 23 Sep 2003 02:53:56 -0000 1.2
@@ -54,13 +54,6 @@
* <http://www.apache.org/>.
*/
-import java.io.BufferedInputStream;
-import java.io.IOException;
-import java.io.InputStream;
-import java.io.OutputStream;
-import org.apache.commons.net.io.FromNetASCIIInputStream;
-import org.apache.commons.net.io.ToNetASCIIOutputStream;
-
/***
* The TelnetNotificationHandler interface can be used to handle
* notification of options negotiation commands received on a telnet
1.4 +2 -6 jakarta-commons/net/src/test/org/apache/commons/net/telnet/TelnetClientTest.java
Index: TelnetClientTest.java
===================================================================
RCS file: /home/cvs/jakarta-commons/net/src/test/org/apache/commons/net/telnet/TelnetClientTest.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- TelnetClientTest.java 10 Aug 2003 09:23:32 -0000 1.3
+++ TelnetClientTest.java 23 Sep 2003 02:53:56 -0000 1.4
@@ -448,12 +448,7 @@
};
byte buffread2b[] = new byte[11];
- byte send2b[] =
- {
- (byte)TelnetCommand.IAC, (byte)TelnetCommand.SB, (byte)TelnetOption.TERMINAL_TYPE,
- (byte)1, (byte)TelnetCommand.IAC, (byte)TelnetCommand.SE,
- };
-
+
openConnections();
numdo = 0;
@@ -594,6 +589,7 @@
OutputStream os = server3.getOutputStream();
InputStream is = server3.getInputStream();
TelnetTestResponder tr = new TelnetTestResponder(is, os, inputs, outputs, 30000);
+ assertNotNull(tr);
boolean res1 = tc3.sendAYT(2000);
if(res1 == true)