You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Li Li <li...@cloudera.com> on 2015/11/09 20:41:01 UTC
Re: Review Request 39824: SENTRY-936: getGroup and getUser should
always
return orginal hdfs values for paths in prefix which are not sentry managed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39824/#review105725
-----------------------------------------------------------
sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationProvider.java (line 250)
<https://reviews.apache.org/r/39824/#comment164352>
move this line to line 249?
sentry-hdfs/sentry-hdfs-namenode-plugin/src/test/java/org/apache/sentry/hdfs/SentryAuthorizationInfoX.java (line 32)
<https://reviews.apache.org/r/39824/#comment164354>
maybe declare a final static string for "test.stale", since it will be used in many places eg. TestSentryAuthorizationProvider.java
- Li Li
On Oct. 30, 2015, 9:42 p.m., Sravya Tirukkovalur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39824/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2015, 9:42 p.m.)
>
>
> Review request for sentry, Anne Yu, Hao Hao, Lenni Kuff, and Ryan Pridgeon.
>
>
> Bugs: SENTRY-936
> https://issues.apache.org/jira/browse/SENTRY-936
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Paths which do not correspond to hive objects should not be affected by Sentry HDFS sync.
> We should update getGroup/getUser/getPermission and getACL
>
> Old behavior:
> If in prefix + unmanaged:
> - Not stale: defaultProvider
> - Stale: hive:hive, 771
> If managed : hive:hive, 771
>
> New behavior:
> If in prefix + unmanaged: defaultProvider
> If managed : hive:hive, 771
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationProvider.java d167183bcac8f56dd58bda0e4ff8406dbd3ad60c
> sentry-hdfs/sentry-hdfs-namenode-plugin/src/test/java/org/apache/sentry/hdfs/SentryAuthorizationInfoX.java 4cebed2ef67ff6e4135441a737ed8ad494c84af8
> sentry-hdfs/sentry-hdfs-namenode-plugin/src/test/java/org/apache/sentry/hdfs/TestSentryAuthorizationProvider.java 40b803e6be2c98cc97ef0baf67e6736d97208b6f
>
> Diff: https://reviews.apache.org/r/39824/diff/
>
>
> Testing
> -------
>
> Existing tests pass. Added a new unit test for stale case validation.
>
>
> Thanks,
>
> Sravya Tirukkovalur
>
>