You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Imran Ghory (JIRA)" <ji...@apache.org> on 2007/08/23 01:52:31 UTC
[jira] Created: (HARMONY-4671) [text] DecimalFormat readObject
contains dead code
[text] DecimalFormat readObject contains dead code
---------------------------------------------------
Key: HARMONY-4671
URL: https://issues.apache.org/jira/browse/HARMONY-4671
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Imran Ghory
The following branch can never get executed as no integer can be greater than Integer.MAX_VALUE:
if (super.getMaximumIntegerDigits() > Integer.MAX_VALUE
|| super.getMinimumIntegerDigits() > Integer.MAX_VALUE
|| super.getMaximumFractionDigits() > Integer.MAX_VALUE
|| super.getMinimumIntegerDigits() > Integer.MAX_VALUE) {
// text.09=The deserialized date is invalid
throw new InvalidObjectException(Messages.getString("text.09")); //$NON-NLS-1$
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-4671) [text] DecimalFormat readObject
contains dead code
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison resolved HARMONY-4671.
----------------------------------
Resolution: Fixed
Thanks Imran.
Unnecessary code removed from DecimalFormal.java in TEXT module at repo revision r568962.
Please check it was fixed as you expected.
> [text] DecimalFormat readObject contains dead code
> ---------------------------------------------------
>
> Key: HARMONY-4671
> URL: https://issues.apache.org/jira/browse/HARMONY-4671
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Imran Ghory
> Assignee: Tim Ellison
>
> The following branch can never get executed as no integer can be greater than Integer.MAX_VALUE:
> if (super.getMaximumIntegerDigits() > Integer.MAX_VALUE
> || super.getMinimumIntegerDigits() > Integer.MAX_VALUE
> || super.getMaximumFractionDigits() > Integer.MAX_VALUE
> || super.getMinimumIntegerDigits() > Integer.MAX_VALUE) {
> // text.09=The deserialized date is invalid
> throw new InvalidObjectException(Messages.getString("text.09")); //$NON-NLS-1$
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4671) [text] DecimalFormat readObject
contains dead code
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison updated HARMONY-4671:
---------------------------------
Assignee: Tim Ellison
> [text] DecimalFormat readObject contains dead code
> ---------------------------------------------------
>
> Key: HARMONY-4671
> URL: https://issues.apache.org/jira/browse/HARMONY-4671
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Imran Ghory
> Assignee: Tim Ellison
>
> The following branch can never get executed as no integer can be greater than Integer.MAX_VALUE:
> if (super.getMaximumIntegerDigits() > Integer.MAX_VALUE
> || super.getMinimumIntegerDigits() > Integer.MAX_VALUE
> || super.getMaximumFractionDigits() > Integer.MAX_VALUE
> || super.getMinimumIntegerDigits() > Integer.MAX_VALUE) {
> // text.09=The deserialized date is invalid
> throw new InvalidObjectException(Messages.getString("text.09")); //$NON-NLS-1$
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-4671) [text] DecimalFormat readObject
contains dead code
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison closed HARMONY-4671.
--------------------------------
No response, assuming it is ok.
> [text] DecimalFormat readObject contains dead code
> ---------------------------------------------------
>
> Key: HARMONY-4671
> URL: https://issues.apache.org/jira/browse/HARMONY-4671
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Imran Ghory
> Assignee: Tim Ellison
>
> The following branch can never get executed as no integer can be greater than Integer.MAX_VALUE:
> if (super.getMaximumIntegerDigits() > Integer.MAX_VALUE
> || super.getMinimumIntegerDigits() > Integer.MAX_VALUE
> || super.getMaximumFractionDigits() > Integer.MAX_VALUE
> || super.getMinimumIntegerDigits() > Integer.MAX_VALUE) {
> // text.09=The deserialized date is invalid
> throw new InvalidObjectException(Messages.getString("text.09")); //$NON-NLS-1$
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.