You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/08/12 22:59:31 UTC
[GitHub] [commons-imaging] gwlucastrig opened a new pull request #93: Raster subset fix
gwlucastrig opened a new pull request #93:
URL: https://github.com/apache/commons-imaging/pull/93
To my embarrassment, I discovered a bug in the indexing logic for reading a partial raster from a floating-point raster data set. This patch addresses the problem. To avoid future mistakes, I have extended the unit test for partial read operations.
In the differences below, you will see sections in the TiffFloatingPointReadTest.java class where blocks of code have been removed. These were consolidated and transferred into the checkSubImage() method in order to support the increased number of geometries tested by the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-imaging] gwlucastrig commented on pull request #93: [IMAGING-263] Fix for raster subset access
Posted by GitBox <gi...@apache.org>.
gwlucastrig commented on pull request #93:
URL: https://github.com/apache/commons-imaging/pull/93#issuecomment-673157891
I enterred JIRA issue Imaging-263. I am finished with this change and will be moving on to my next issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-imaging] coveralls commented on pull request #93: Imaging-263 Fix for raster subset access
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #93:
URL: https://github.com/apache/commons-imaging/pull/93#issuecomment-673156791
[](https://coveralls.io/builds/32718938)
Coverage decreased (-0.003%) to 76.308% when pulling **a0ba592c1c0080a26dc65ec88c07755dd18dd80f on gwlucastrig:RasterSubsetFix** into **789f157619f8755855afdf7956111f4efff93a18 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-imaging] kinow closed pull request #93: [IMAGING-263] Fix for raster subset access
Posted by GitBox <gi...@apache.org>.
kinow closed pull request #93:
URL: https://github.com/apache/commons-imaging/pull/93
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-imaging] kinow commented on pull request #93: [IMAGING-263] Fix for raster subset access
Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #93:
URL: https://github.com/apache/commons-imaging/pull/93#issuecomment-673159519
> I enterred JIRA issue Imaging-263. I am finished with this change and will be moving on to my next issue.
Thanks @gwlucastrig ! This one should be merged by tonight (NZtime).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-imaging] coveralls edited a comment on pull request #93: [IMAGING-263] Fix for raster subset access
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #93:
URL: https://github.com/apache/commons-imaging/pull/93#issuecomment-673156791
[](https://coveralls.io/builds/32719386)
Coverage increased (+0.003%) to 76.314% when pulling **0166737c0356da050f5076d0b709028679984da1 on gwlucastrig:RasterSubsetFix** into **789f157619f8755855afdf7956111f4efff93a18 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-imaging] kinow commented on pull request #93: [IMAGING-263] Fix for raster subset access
Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #93:
URL: https://github.com/apache/commons-imaging/pull/93#issuecomment-673192390
Merged, thanks @gwlucastrig !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org