[jira] [Commented] (HDFS-12873) Creating a '..' directory is possible using inode paths

["Rushabh S Shah (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-12873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272829#comment-16272829 ] 

Rushabh S Shah commented on HDFS-12873:
---------------------------------------

I wrote a samp
{noformat}
    Configuration conf = new Configuration();
    FileSystem fileSystem = FileSystem.get(conf);
    DistributedFileSystem dfsFileSystem = (DistributedFileSystem)fileSystem;
    DFSClient client = dfsFileSystem.getClient();
    String fileName = "/user/rushabhs/benchmarks/";
    HdfsFileStatus status = client.getFileInfo(fileName);
    Path mkdirPath = new Path("/.reserved/.inodes/"+ status.getFileId() + "/TestDFSIO/../test2");
    dfsFileSystem.mkdirs(mkdirPath, new FsPermission("777"));
{noformat}
It did create {{test2}} directory underneath {{/user/rushabhs/benchmarks/}}.
I ran the same test via fsshell also. It worked as expected.
[~raemarks]: I am running some version of 2.8.2 release which shouldn't be that different from 2.8.0
Can you confirm that you are seeing this in {{2.8.0}} and if possible can you share your program/script.

> Creating a '..' directory is possible using inode paths
> -------------------------------------------------------
>
>                 Key: HDFS-12873
>                 URL: https://issues.apache.org/jira/browse/HDFS-12873
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs, namenode
>    Affects Versions: 2.8.0
>         Environment: Apache NameNode running in a Docker container on a Fedora 25 workstation.
>            Reporter: Raeanne J Marks
>
> Start with a fresh deployment of HDFS.
> 1. Mkdirs '/x/y/z'
> 2. use GetFileInfo to get y's inode number
> 3. Mkdirs '/.reserved/.inodes/<y's inode number>/z/../foo'
> Expectation: The path in step 3 is rejected as invalid (exception thrown) OR foo would be created under y.
> Observation: This created a directory called '..' under z and 'foo' under that '..' directory instead of consolidating the path to '/x/y/foo' or throwing an exception. GetListing on '/.reserved/.inodes/<z's inode number>' shows '..', while GetListing on '/x/y' does not.
> Mkdirs INotify events were reported with the following paths, in order:
> /x
> /x/y
> /x/y/z
> /x/y/z/..
> /x/y/z/../foo
> I can also chain these dotdot directories and make them as deep as I want. Mkdirs works with the following paths appended to the inode path for directory y: '/z/../../../foo', '/z/../../../../../', '/z/../../../foo/bar/../..' etc, and it constructs all the '..' directories as if they weren't special names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org