You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/03 21:27:00 UTC
[jira] [Commented] (DRILL-6068) Drill should support
user/distribution specific configuration checks during startup
[ https://issues.apache.org/jira/browse/DRILL-6068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310305#comment-16310305 ]
ASF GitHub Bot commented on DRILL-6068:
---------------------------------------
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/1081
DRILL-6068: Support user/distrib-specific config checks during startup
1. Allows for distrib/user specific checks to be done
2. Place-holder files for distribution and user specific checks
3. Moved JVM Version Check to head of script
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kkhatua/drill DRILL-6068
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/1081.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1081
----
commit 2fea048835f729175f77b0a0dea731f741bb70e9
Author: Kunal Khatua <kk...@...>
Date: 2018-01-03T21:22:52Z
DRILL-6068: Support user/distrib-specific config checks during startup
1. Allows for distrib/user specific checks to be done
2. Place-holder files for distribution and user specific checks
3. Moved JVM Version Check to head of script
----
> Drill should support user/distribution specific configuration checks during startup
> -----------------------------------------------------------------------------------
>
> Key: DRILL-6068
> URL: https://issues.apache.org/jira/browse/DRILL-6068
> Project: Apache Drill
> Issue Type: New Feature
> Affects Versions: 1.12.0
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
> Labels: newbie
> Fix For: 1.13.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> This is an evolution of the problem stated in DRILL-5741.
> Currently, Drill does not leverage any information about the host machine during start up and makes assumptions about the available resources (like memory).
> Further more, it is, often, up to the user to define the individual parameters of memory for Drill: Heap, Direct and CodeCache.
> The idea is to introduce a distribution and user specific configuration checking scripts (distrib-auto.sh and drill-auto.sh) which follow the same precedence as on the lines of distrib-env.sh and drill-env.sh.
> A check for the existence of the `distrib-auto.sh` / `drill-auto.sh` scripts will be performed and executed only if there is any executable lines of code. Otherwise, the expected behaviour is that the startup functionality Drill will continue as previous versions.
> In combination with the requirement described for DRILL-5741; it would be nice if a starting up Drillbit could be told upfront on the amount of memory it can assume to access and automatically perform the allocations for the individual parameters, while providing the ability for users to override (some or all of) those settings.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)