You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/03/11 03:05:37 UTC
[GitHub] [incubator-dolphinscheduler] break60 opened a new pull request
#2141: Limit customization file content to no more than 3000 lines(#2128)
break60 opened a new pull request #2141: Limit customization file content to no more than 3000 lines(#2128)
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2141
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue
#2141: Limit customization file content to no more than 3000 lines(#2128)
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #2141: Limit customization file content to no more than 3000 lines(#2128)
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2141#issuecomment-597422707
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2141&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/C.png' alt='C' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2141&resolved=false&types=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2141&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2141&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2141&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2141&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2141&resolved=false&types=SECURITY_HOTSPOT) [3 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2141&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2141&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2141&resolved=false&types=CODE_SMELL) [139 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2141&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/25.png' alt='25.7%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2141&metric=new_coverage&view=list) [25.7% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2141&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.7%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2141&metric=new_duplicated_lines_density&view=list) [0.7% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2141&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong merged pull request #2141:
Limit customization file content to no more than 3000 lines(#2128)
Posted by GitBox <gi...@apache.org>.
dailidong merged pull request #2141: Limit customization file content to no more than 3000 lines(#2128)
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2141
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #2141:
Limit customization file content to no more than 3000 lines(#2128)
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #2141: Limit customization file content to no more than 3000 lines(#2128)
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2141#issuecomment-597421960
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2141?src=pr&el=h1) Report
> Merging [#2141](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2141?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/450a1f56fc73f088fce89a343a0b008706f2088c?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2141?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #2141 +/- ##
============================================
- Coverage 29.86% 29.82% -0.04%
- Complexity 1628 1632 +4
============================================
Files 336 336
Lines 17822 17835 +13
Branches 2250 2249 -1
============================================
- Hits 5322 5320 -2
- Misses 11935 11950 +15
Partials 565 565
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2141?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...duler/server/worker/task/ShellCommandExecutor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2141/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL1NoZWxsQ29tbWFuZEV4ZWN1dG9yLmphdmE=) | `56.52% <0%> (-26.09%)` | `4% <0%> (-3%)` | |
| [...nscheduler/server/worker/task/shell/ShellTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2141/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL3NoZWxsL1NoZWxsVGFzay5qYXZh) | `70.83% <0%> (-6.25%)` | `5% <0%> (-2%)` | |
| [...er/server/worker/task/AbstractCommandExecutor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2141/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL0Fic3RyYWN0Q29tbWFuZEV4ZWN1dG9yLmphdmE=) | `36.74% <0%> (-4.66%)` | `14% <0%> (-1%)` | |
| [...uler/common/utils/process/ProcessImplForWin32.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2141/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL3Byb2Nlc3MvUHJvY2Vzc0ltcGxGb3JXaW4zMi5qYXZh) | `0.66% <0%> (-0.39%)` | `1% <0%> (ø)` | |
| [.../apache/dolphinscheduler/common/utils/OSUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2141/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL09TVXRpbHMuamF2YQ==) | `48% <0%> (-0.35%)` | `23% <0%> (+1%)` | |
| [.../dolphinscheduler/server/utils/FlinkArgsUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2141/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL0ZsaW5rQXJnc1V0aWxzLmphdmE=) | `88.46% <0%> (-0.22%)` | `10% <0%> (-1%)` | |
| [...duler/server/worker/runner/TaskScheduleThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2141/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9ydW5uZXIvVGFza1NjaGVkdWxlVGhyZWFkLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...inscheduler/common/task/sqoop/SqoopParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2141/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3Fvb3AvU3Fvb3BQYXJhbWV0ZXJzLmphdmE=) | `80% <0%> (ø)` | `15% <0%> (ø)` | :arrow_down: |
| [...pache/dolphinscheduler/common/utils/FileUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2141/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0ZpbGVVdGlscy5qYXZh) | `20% <0%> (+2.41%)` | `9% <0%> (+2%)` | :arrow_up: |
| [...he/dolphinscheduler/common/thread/ThreadUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2141/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9UaHJlYWRVdGlscy5qYXZh) | `77.96% <0%> (+6.77%)` | `13% <0%> (+1%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2141/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2141?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2141?src=pr&el=footer). Last update [450a1f5...84bcdc7](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2141?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services