You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/11/04 03:46:29 UTC
[GitHub] [zookeeper] maoling commented on a change in pull request #1128:
Various code clean-upsFix comment
maoling commented on a change in pull request #1128: Various code clean-upsFix comment
URL: https://github.com/apache/zookeeper/pull/1128#discussion_r341897810
##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/client/StaticHostProvider.java
##########
@@ -331,7 +331,7 @@ private InetSocketAddress nextHostInReconfigMode() {
return null;
}
- public InetSocketAddress next(long spinDelay) {
+ public InetSocketAddress next(long delay) {
Review comment:
IIUC, `serverAddresses` is a bit like Circular Queue, when spinDelay>0 and serverAddresses list is too short(e.g size=1), to avoid connecting that server quickly again, it will sleep `spinDelay`.That's why the word:`spin` used
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services