[PR] [fix](storage) Preserve resource and vault ALTER patch semantics [doris]

["sollhui (via GitHub)" <gi...@apache.org>]

sollhui opened a new pull request, #69549:
URL: https://github.com/apache/doris/pull/69549

   ### What problem does this PR solve?
   
   Related PR: #68540
   
   Resource ALTER validated a different property map from the one it published, and vault ALTER could replace omitted AWS credential fields or persist a rename after rejecting the credential update.
   
   This independent prerequisite:
   
   - Serializes resource snapshot, effective-property validation, and publication; normalizes legacy aliases before applying the patch.
   - Separates vault CREATE defaults from ALTER field presence. Role, external ID, and credential-provider updates preserve omitted fields, while explicit clears remain meaningful.
   - Validates the effective AWS/static-key state and applies vault/name changes to a candidate, returning before persistence when validation fails.
   - Rejects misplaced object-store properties before HDFS vault connectivity checks.
   
   The branch is based directly on `master` at `31615e01791`. It contains no GCP SDK dependencies, native credential types, or protocol changes. Review and merge this prerequisite before #68540.
   
   ### Release note
   
   Resource and vault ALTER preserve omitted configuration, serialize resource updates, and avoid publishing partial metadata after a failed update. Clearing an unused AWS role preserves static keys and encryption metadata.
   
   ### Validation
   
   - Passed: FE Core Checkstyle; parsing of all six changed Java files; clang-format 16 checks on all four changed C++ files; `git diff --check`.
   - Added/extracted coverage: concurrent resource updates, legacy endpoint aliases, CREATE/ALTER request field presence, repeated role clears with encrypted keys, independent AWS field updates, rejected rename persistence, and HDFS property validation.
   - Not executed: FE unit tests. The standard runner stopped because installed Thrift 0.16.0 does not match required 0.24.0.
   - Not executed: Cloud compilation/unit tests. `build.sh --cloud` stopped during thirdparty setup because the required LLVM 20 compiler is unavailable.
   
   ### Check List (For Author)
   
   - Test: unit coverage included; execution limitations above.
   - Behavior changed: Yes, ALTER patch preservation and atomic publication.
   - Does this need documentation: No new configuration properties.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [PR] [fix](storage) Preserve resource and vault ALTER patch semantics [doris]

["hello-stephen (via GitHub)" <gi...@apache.org>]

hello-stephen commented on PR #69549:
URL: https://github.com/apache/doris/pull/69549#issuecomment-6365887623

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://doris.apache.org/community/how-to-contribute/review-and-ci).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org