You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2025/06/14 00:14:57 UTC
[Impala-ASF-CR] Use Google TcMalloc
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22913
to look at the new patch set (#7).
Change subject: Use Google TcMalloc
......................................................................
Use Google TcMalloc
This swaps out the gperftools code for Google tcmalloc. The
definitions of some metrics changed, so this moves from using
PHYSICAL_BYTES_RESERVED to TOTAL_BYTES_RESERVED for memory
used.
This starts a background thread freeing memory at 10MB / sec.
Google TcMalloc benefits from having transparent huge pages
turned on to the "always" mode.
FE tests, ASAN/TSAN builds are currently broken.
Change-Id: Ib224895c43c59671ad58a90d1cfdea8ae7bde6e5
---
M CMakeLists.txt
M be/CMakeLists.txt
M be/src/common/CMakeLists.txt
M be/src/common/init.cc
M be/src/runtime/CMakeLists.txt
M be/src/runtime/bufferpool/system-allocator.cc
M be/src/runtime/exec-env.cc
M be/src/runtime/query-exec-mgr.cc
M be/src/util/CMakeLists.txt
M be/src/util/memory-metrics.cc
M be/src/util/memory-metrics.h
M be/src/util/memusage-path-handlers.cc
M be/src/util/pprof-path-handlers.cc
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
15 files changed, 96 insertions(+), 63 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/22913/7
--
To view, visit http://gerrit.cloudera.org:8080/22913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib224895c43c59671ad58a90d1cfdea8ae7bde6e5
Gerrit-Change-Number: 22913
Gerrit-PatchSet: 7
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>