Re: [PR] Add base_dir parameter to SSH remote job validation and cleanup functions [airflow]

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk commented on PR #70788:
URL: https://github.com/apache/airflow/pull/70788#issuecomment-5151458899

   Thanks for this, and sorry to close it — you hit a bug that three people found independently. #69885 has been open for it since 14 July and is the one I am going with.
   
   The deciding factor is test coverage: this changes `_validate_job_dir` and both cleanup builders but adds no tests. That function is a safety guard, so the behaviour most worth pinning is what it *rejects* — a job dir outside the configured base must still raise. #69885 covers that on both POSIX and Windows.
   
   Worth knowing that #70091 has since rewritten those same builders on `main`, so this branch conflicts regardless now.
   
   The diagnosis was right, and independently arriving at the same fix as two other people is a reasonable signal. Please do keep going at the SSH provider.
   
   ---
   Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org