You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/30 05:29:44 UTC

[GitHub] [flink] godfreyhe opened a new pull request #11558: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate

godfreyhe opened a new pull request #11558: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11558
 
 
   
   ## What is the purpose of the change
   
   *currently AggregateProjectPullUpConstantsRule is in cost-based phase (logical phase), while RelMdPredicates does not work when meeting RelSubset. So we can add AggregateProjectPullUpConstantsRule into hep planner to fix the bug. cherry pick from https://github.com/apache/flink/pull/11158*
   
   
   ## Brief change log
   
     - *add AggregateProjectPullUpConstantsRule into default_write phase*
   
   
   ## Verifying this change
   
   
   
   This change added tests and can be verified as follows:
   
     - *Added testGroupByConstantKey method in AggregateTest to validate constant group key in queries*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on issue #11558: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #11558: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11558#issuecomment-605843655
 
 
   Merged #11558 into release-1.10

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11558: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11558: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11558#issuecomment-605793624
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "67d546754c4817983c7ddad7f7253c5ec24e28e4",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156431519",
       "triggerID" : "67d546754c4817983c7ddad7f7253c5ec24e28e4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 67d546754c4817983c7ddad7f7253c5ec24e28e4 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/156431519) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11558: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11558: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11558#issuecomment-605791081
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 67d546754c4817983c7ddad7f7253c5ec24e28e4 (Mon Mar 30 05:32:36 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11558: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11558: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11558#issuecomment-605793624
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "67d546754c4817983c7ddad7f7253c5ec24e28e4",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156431519",
       "triggerID" : "67d546754c4817983c7ddad7f7253c5ec24e28e4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 67d546754c4817983c7ddad7f7253c5ec24e28e4 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/156431519) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11558: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11558: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11558#issuecomment-605793624
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "67d546754c4817983c7ddad7f7253c5ec24e28e4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "67d546754c4817983c7ddad7f7253c5ec24e28e4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 67d546754c4817983c7ddad7f7253c5ec24e28e4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi merged pull request #11558: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate

Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #11558: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11558
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services