You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by vi...@apache.org on 2026/10/16 21:39:34 UTC

(superset-kubernetes-operator) branch main updated: docs(lifecycle): fix seed type casing and misplaced text (#449)

This is an automated email from the ASF dual-hosted git repository.

villebro pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/superset-kubernetes-operator.git


The following commit(s) were added to refs/heads/main by this push:
     new 58884e2  docs(lifecycle): fix seed type casing and misplaced text (#449)
58884e2 is described below

commit 58884e2afd5dd8ae74864a515fbd1f9ec6b8c2de
Author: Younsung Lee <cy...@kakao.com>
AuthorDate: Sat Oct 17 06:39:28 2026 +0900

    docs(lifecycle): fix seed type casing and misplaced text (#449)
    
    The lifecycle guide had three small mistakes that disagree with the
    code or with other parts of the same page.
    
    The seed image table listed the source types as "postgresql" and
    "mysql". The CRD enum only accepts "PostgreSQL" and "MySQL", so a user
    who copied the value from the table would get a validation error. The
    table now uses the real enum values.
    
    The paragraph that explains what happens when a task is disabled sat at
    the end of the "Alternative: external CronJob" part of Scheduled
    Execution, where it reads as if it were about CronJobs. It now sits
    right after the "disabled: true" example under Disabling Tasks.
    
    The checksum chain under Pipeline Checksum Model left createDatabase
    out of the migrate checksum. The trigger table near the top of the page
    and migrateInputs in internal/controller/lifecycle_migrate.go both
    include it, so the formula now lists it too.
    
    Signed-off-by: younsl <cy...@kakao.com>
---
 docs/user-guide/lifecycle.md | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/docs/user-guide/lifecycle.md b/docs/user-guide/lifecycle.md
index 1b2327f..4059718 100644
--- a/docs/user-guide/lifecycle.md
+++ b/docs/user-guide/lifecycle.md
@@ -77,6 +77,8 @@ spec:
       disabled: true  # user manages migrations externally
 ```
 
+When disabled, the task's Job and ConfigMap are deleted, its projected status is cleared from the parent, and it does not participate in the pipeline. Downstream tasks still run but don't receive propagation from the disabled task.
+
 ### Scheduled Execution
 
 Tasks that support scheduling (currently seed) accept a `cronSchedule` field — a standard cron expression (5 to 7 fields; the sixth/seventh fields add optional seconds and year precision) that triggers periodic re-execution:
@@ -114,8 +116,6 @@ The seed task status includes `lastScheduledAt` (the tick that triggered the mos
 
 For teams that prefer external scheduling, a Kubernetes CronJob can patch the `trigger` field on a cron schedule. This requires a CronJob resource, ServiceAccount, RoleBinding, and a kubectl image, but keeps the scheduling logic outside the operator.
 
-When disabled, the task's Job and ConfigMap are deleted, its projected status is cleared from the parent, and it does not participate in the pipeline. Downstream tasks still run but don't receive propagation from the disabled task.
-
 ## Upgrade Mode
 
 The `upgradeMode` field controls how image upgrades are handled:
@@ -536,8 +536,8 @@ The seed pod uses a database-tool image (not the Superset image):
 
 | Source type | Default image |
 |---|---|
-| `postgresql` | `postgres:17-alpine` |
-| `mysql` | `mysql:8.4` |
+| `PostgreSQL` | `postgres:17-alpine` |
+| `MySQL` | `mysql:8.4` |
 
 Override with `seed.image` if you need additional tools.
 
@@ -559,7 +559,7 @@ The lifecycle uses a **checksum chain** to determine which tasks execute and whi
                          ↓
 seed.checksum   = hash(parentUID, "Seed", command, trigger, scheduleTick, source, excludes, postSeedSQL, seedImage, targetImage)
                          ↓ (stored in parent status on completion)
-migrate.checksum = hash(seed.status.checksum, "Migrate", command, trigger, image)
+migrate.checksum = hash(seed.status.checksum, "Migrate", command, trigger, image, createDatabase)
                          ↓ (stored in parent status on completion)
 rotate.checksum  = hash(migrate.status.checksum, "Rotate", command, trigger, image, secretKey, secretKeyFrom, previousSecretKey, previousSecretKeyFrom)
                          ↓ (stored in parent status on completion)