You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Sean Owen (JIRA)" <ji...@apache.org> on 2009/09/09 17:44:58 UTC

[jira] Resolved: (MAHOUT-175) Use IOUtils, FileLineIterable/Iterator across the project

     [ https://issues.apache.org/jira/browse/MAHOUT-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Owen resolved MAHOUT-175.
------------------------------

    Resolution: Fixed

> Use IOUtils, FileLineIterable/Iterator across the project
> ---------------------------------------------------------
>
>                 Key: MAHOUT-175
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-175
>             Project: Mahout
>          Issue Type: Improvement
>    Affects Versions: 0.2
>            Reporter: Sean Owen
>            Assignee: Sean Owen
>            Priority: Minor
>             Fix For: 0.2
>
>         Attachments: MAHOUT-175.patch
>
>
> The patch I will attach does a couple things:
> Uses FileLineIterable/Iterator for iterating over lines of a file. This is slightly tidier, but also addresses a few subtle issues across the code base, where reading of files did not always end by closing the stream, or, relied on platform default character encoding.
> Uses IOUtils consistently to close Closeables, swallowing and logging exceptions in cases where they are not to be treated as errors.
> Finally, fixes some issues in ARFFIterator while I'm at it -- hasNext() changes state, when next() should, and next() did not throw NoSuchElementException

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.