You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/17 11:47:42 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #5465: ui: Move resource icon to first colume for VM list view
Pearl1594 opened a new pull request #5465:
URL: https://github.com/apache/cloudstack/pull/5465
### Description
This PR moves the resource icon to the first column - VM Name - in the Instance List View. With the following change https://github.com/apache/cloudstack/commit/413d10dd8106af9b3c369c1a393fbcca5e7217ce#diff-93b52572e13887859e26011826bd9744351c29e7a0de514ea308d503113a13e3L41-R41 the icon now appears on the second column, which looks odd.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [X] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Prior Fix:
Post Fix:
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5465: ui: Move resource icon to first column for VM list view
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5465:
URL: https://github.com/apache/cloudstack/pull/5465#issuecomment-921867895
Sorry @DaanHoogland , are you referring to the Icons appearing in black as dark-mode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5465: ui: Move resource icon to first column for VM list view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5465:
URL: https://github.com/apache/cloudstack/pull/5465#issuecomment-921739097
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5465 (SL-JID-661)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #5465: ui: Move resource icon to first column for VM list view
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5465:
URL: https://github.com/apache/cloudstack/pull/5465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5465: ui: Move resource icon to first column for VM list view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5465:
URL: https://github.com/apache/cloudstack/pull/5465#issuecomment-921736403
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5465: ui: Move resource icon to first column for VM list view
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5465:
URL: https://github.com/apache/cloudstack/pull/5465#issuecomment-921735712
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5465: ui: Move resource icon to first column for VM list view
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5465:
URL: https://github.com/apache/cloudstack/pull/5465#issuecomment-921857714
hm, default dark mode??? i think i should have -1ed something somewhere :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org