You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/16 09:23:33 UTC
[GitHub] [spark] yaooqinn commented on a change in pull request #27906:
[SPARK-31150][SQL] Parsing seconds fraction with variable length for
timestamp
yaooqinn commented on a change in pull request #27906: [SPARK-31150][SQL] Parsing seconds fraction with variable length for timestamp
URL: https://github.com/apache/spark/pull/27906#discussion_r392879558
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVInferSchema.scala
##########
@@ -34,7 +34,8 @@ class CSVInferSchema(val options: CSVOptions) extends Serializable {
options.timestampFormat,
options.zoneId,
options.locale,
- legacyFormat = FAST_DATE_FORMAT)
+ legacyFormat = FAST_DATE_FORMAT,
+ varLenEnabled = options.timestampFormat.contains('S'))
Review comment:
I have updated this, and mv the cache optimization to `DateTimeFormatterHelper`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org