You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/04 21:13:46 UTC
[GitHub] [spark] vanzin commented on issue #24245: [SPARK-13704][CORE][YARN]
Reduce rack resolution time
vanzin commented on issue #24245: [SPARK-13704][CORE][YARN] Reduce rack resolution time
URL: https://github.com/apache/spark/pull/24245#issuecomment-480066056
Looks fine. I still think that `getRackForHosts` could just return a `Seq[String]` and avoid using `Option` at all - the code in `SparkRackResolver` doesn't seem to ever return a `null` location, but not worth delaying this patch more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org