[jira] [Commented] (FELIX-6337) Maven Bundle Plugin generates incorrect Provide-Capability

["Robert Varga (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225695#comment-17225695 ] 

Robert Varga commented on FELIX-6337:
-------------------------------------

[~gnodet] based on the feedback [https://github.com/bndtools/bnd/issues/4391] it looks as though sort of header values should be unnecessary. I do not see anything in FELIX-6269. which would require mucking with attribute values.

Based on that, I propose to revert [https://github.com/apache/felix-dev/commit/76dba132d4abbab75f20dc5096649842c52e4810]

If we come across a bnd header which would need this treatment, bnd has asked us to file an issue, as their every intention is to provide reproducible headers.

 

> Maven Bundle Plugin generates incorrect Provide-Capability
> ----------------------------------------------------------
>
>                 Key: FELIX-6337
>                 URL: https://issues.apache.org/jira/browse/FELIX-6337
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven Bundle Plugin
>    Affects Versions: maven-bundle-plugin-5.1.1
>            Reporter: Robert Varga
>            Priority: Critical
>              Labels: regression
>
> When presented with the following:
> {code:java}
> @Component(immediate = true, service = { CacheManagers.class, CacheManagersRegistry.class })
> public class CacheManagersRegistryImpl implements CacheManagersRegistry {
> {code}
> maven-bundle-plugin-5.1.1 generates the following:
> {noformat}
> Provide-Capability: osgi.service;uses:="org.opendaylight.infrautils.cach
>  es,org.opendaylight.infrautils.caches.baseimpl";objectClass="org.openda
>  ylight.infrautils.caches.CacheManagers,org.opendaylight.infrautils.cach
>  es.baseimpl.CacheManagersRegistry"
> {noformat}
> whereas maven-bundle-plugin-4.2.1 generates the following:
> {noformat}
> Provide-Capability: osgi.service;objectClass:List<String>="org.opendayli
>  ght.infrautils.caches.CacheManagers,org.opendaylight.infrautils.caches.
>  baseimpl.CacheManagersRegistry"
> {noformat}
> It seems the List<String> part is getting lost, hence the value is treated as a single String – which leads to at least Karaf failing to install dependent bundles.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)