You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Radu Cotescu <ra...@apache.org> on 2018/12/18 15:51:00 UTC
[jdk bug] for those of you on Mac running JDK 1.8
Hi,
I’ve submitted yesterday this bug [0] to Oracle. TL;DR: one cannot build the org.apache.sling.api JavaDocs with JDK 8 on macOS. It all started with [1], but it’s obviously a JDK bug.
Cheers,
Radu
[0] - https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8215542 <https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8215542>
[1] - https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6 <https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6>
Re: [jdk bug] for those of you on Mac running JDK 1.8
Posted by Konrad Windszus <ko...@gmx.de>.
IMHO no need to enforce building with Java 11. It is just that you need Java 9 or newer to circumvent that bug. But you can use Java 11 as well if you want to, but I don't see a reason to enforce that right now.
> On 7. Jan 2019, at 14:11, Julian Reschke <ju...@gmx.de> wrote:
>
> On 2019-01-07 09:18, Konrad Windszus wrote:
>> I enforced now JDK9 or newer on Macs for Sling API in https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640 <https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640>. We can extend to other operating systems if necessary.
>> ...
>
> FWIW, shouldn't that be Java 11? (9 is EOL already...)
>
> Best regards, Julian
Re: [jdk bug] for those of you on Mac running JDK 1.8
Posted by Julian Reschke <ju...@gmx.de>.
On 2019-01-07 09:18, Konrad Windszus wrote:
> I enforced now JDK9 or newer on Macs for Sling API in https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640 <https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640>. We can extend to other operating systems if necessary.
> ...
FWIW, shouldn't that be Java 11? (9 is EOL already...)
Best regards, Julian
Re: [jdk bug] for those of you on Mac running JDK 1.8
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Mon, Jan 7, 2019 at 9:18 AM Konrad Windszus <ko...@gmx.de> wrote:
>
> I enforced now JDK9 or newer on Macs for Sling API
> in https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640 <https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640>...
I've tweaked that to allow for ignoring that requirement with
-Dignore.javadocjdk so one can still build with jdk8 if not building
javadoc.
-Bertrand
Re: [jdk bug] for those of you on Mac running JDK 1.8
Posted by Carsten Ziegeler <cz...@apache.org>.
Below is my env, I have a newer revision (191). Maybe it's related to that?
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-17T18:33:14Z)
Maven home: /home/cziegeler/Developer/Tools/apache-maven-3.5.4
Java version: 1.8.0_191, vendor: Oracle Corporation, runtime:
/usr/lib/jvm/java-8-oracle/jre
Default locale: en, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-17763-microsoft", arch: "amd64",
family: "unix"
Regards
Carsten
Radu Cotescu wrote
> Now that’s weird. Before opening the JDK bug I chatted to Robert and asked him to run a build on his system:
>
> $ mvn -v
> Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T20:41:47+02:00)
> Maven home: /usr/share/java/maven
> Java version: 1.8.0_181, vendor: Oracle Corporation, runtime: /usr/lib64/jvm/java-1.8.0-openjdk-1.8.0/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.19.7-1-default", arch: "amd64", family: “unix"
>
> On his machine the javadoc generation worked ok.
>
> @Carsten, what JDK are you running?
>
>> On 7 Jan 2019, at 10:13, Carsten Ziegeler <cz...@apache.org> wrote:
>>
>> FWIW I get the same error with Ubuntu and Java8
>
>
--
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org
Re: [jdk bug] for those of you on Mac running JDK 1.8
Posted by Radu Cotescu <ra...@apache.org>.
Now that’s weird. Before opening the JDK bug I chatted to Robert and asked him to run a build on his system:
$ mvn -v
Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T20:41:47+02:00)
Maven home: /usr/share/java/maven
Java version: 1.8.0_181, vendor: Oracle Corporation, runtime: /usr/lib64/jvm/java-1.8.0-openjdk-1.8.0/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.19.7-1-default", arch: "amd64", family: “unix"
On his machine the javadoc generation worked ok.
@Carsten, what JDK are you running?
> On 7 Jan 2019, at 10:13, Carsten Ziegeler <cz...@apache.org> wrote:
>
> FWIW I get the same error with Ubuntu and Java8
Re: [jdk bug] for those of you on Mac running JDK 1.8
Posted by Konrad Windszus <ko...@gmx.de>.
Fixed now via https://issues.apache.org/jira/browse/SLING-8202 <https://issues.apache.org/jira/browse/SLING-8202>.
> On 7. Jan 2019, at 14:45, Konrad Windszus <ko...@gmx.de> wrote:
>
> Tried to do this with https://github.com/apache/sling-org-apache-sling-api/commit/63caf8de12b6187698a2f0f1ed2225f8315e9ce4 <https://github.com/apache/sling-org-apache-sling-api/commit/63caf8de12b6187698a2f0f1ed2225f8315e9ce4>.
> Unfortunately the seed job does not seem to pick that up: https://builds.apache.org/view/S-Z/view/Sling/job/sling-seed-build/168/console <https://builds.apache.org/view/S-Z/view/Sling/job/sling-seed-build/168/console>
>
> I don't even find the entry in the build log for org-apache-sling-api.
> This seems to be due to the fact that entry additionalMavenParams is documented in https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor <https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor> but not evaluated in https://github.com/apache/sling-tooling-jenkins/blob/master/create_jobs.groovy <https://github.com/apache/sling-tooling-jenkins/blob/master/create_jobs.groovy>.
>
> @Robert: Since this is a pretty central piece I don't really dare to do changes here but to me it seems that the variable "module.extraGoalsParams" is never set by anyone. WDYT?
>
> Thanks,
> Konrad
>
>
>
>
>
>> On 7. Jan 2019, at 13:27, Radu Cotescu <ra...@apache.org> wrote:
>>
>> Hi Konrad,
>>
>>> On 7 Jan 2019, at 11:40, Konrad Windszus <ko...@gmx.de> wrote:
>>>
>>> or should I create a .sling-module.xml for the API module setting an explicit property via <additionalMavenParams>
>>
>> I find this approach cleaner and easier to document - setting maven.javadoc.skip to true sounds nicer than a check for a JENKINS_* environment variable.
>>
>> Thanks,
>> Radu
>
Re: [jdk bug] for those of you on Mac running JDK 1.8
Posted by Konrad Windszus <ko...@gmx.de>.
Tried to do this with https://github.com/apache/sling-org-apache-sling-api/commit/63caf8de12b6187698a2f0f1ed2225f8315e9ce4 <https://github.com/apache/sling-org-apache-sling-api/commit/63caf8de12b6187698a2f0f1ed2225f8315e9ce4>.
Unfortunately the seed job does not seem to pick that up: https://builds.apache.org/view/S-Z/view/Sling/job/sling-seed-build/168/console <https://builds.apache.org/view/S-Z/view/Sling/job/sling-seed-build/168/console>
I don't even find the entry in the build log for org-apache-sling-api.
This seems to be due to the fact that entry additionalMavenParams is documented in https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor <https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor> but not evaluated in https://github.com/apache/sling-tooling-jenkins/blob/master/create_jobs.groovy <https://github.com/apache/sling-tooling-jenkins/blob/master/create_jobs.groovy>.
@Robert: Since this is a pretty central piece I don't really dare to do changes here but to me it seems that the variable "module.extraGoalsParams" is never set by anyone. WDYT?
Thanks,
Konrad
> On 7. Jan 2019, at 13:27, Radu Cotescu <ra...@apache.org> wrote:
>
> Hi Konrad,
>
>> On 7 Jan 2019, at 11:40, Konrad Windszus <ko...@gmx.de> wrote:
>>
>> or should I create a .sling-module.xml for the API module setting an explicit property via <additionalMavenParams>
>
> I find this approach cleaner and easier to document - setting maven.javadoc.skip to true sounds nicer than a check for a JENKINS_* environment variable.
>
> Thanks,
> Radu
Re: [jdk bug] for those of you on Mac running JDK 1.8
Posted by Radu Cotescu <ra...@apache.org>.
Hi Konrad,
> On 7 Jan 2019, at 11:40, Konrad Windszus <ko...@gmx.de> wrote:
>
> or should I create a .sling-module.xml for the API module setting an explicit property via <additionalMavenParams>
I find this approach cleaner and easier to document - setting maven.javadoc.skip to true sounds nicer than a check for a JENKINS_* environment variable.
Thanks,
Radu
Re: [jdk bug] for those of you on Mac running JDK 1.8
Posted by Konrad Windszus <ko...@gmx.de>.
Now Jenkins build fails as well. Didn't really think of it...
Any preference on how to disable this for Jenkins?
Should I just check the existence of any of these environment variables: https://stackoverflow.com/a/14242750 <https://stackoverflow.com/a/14242750> or should I create a .sling-module.xml for the API module setting an explicit property via <additionalMavenParams>?
Thanks for your input,
Konrad
> On 7. Jan 2019, at 11:21, Konrad Windszus <ko...@gmx.de> wrote:
>
> Thanks for the confirmation. Always activated the profile now in https://github.com/apache/sling-org-apache-sling-api/commit/62da4e295a799f3c784a10f23079ec2224929b1e.
>
>> On 7. Jan 2019, at 11:17, Carsten Ziegeler <cz...@apache.org> wrote:
>>
>> I get the same error with Windows.
>>
>>
>> Regards
>>
>> Carsten
>>
>>
>> Konrad Windszus wrote
>>> Can anyone check on Windows?
>>> Then I would always enable that profile!
>>>> On 7. Jan 2019, at 10:13, Carsten Ziegeler <cz...@apache.org> wrote:
>>>>
>>>> FWIW I get the same error with Ubuntu and Java8
>>>>
>>>>
>>>> Regards
>>>>
>>>> Carsten
>>>>
>>>>
>>>> Konrad Windszus wrote
>>>>> I enforced now JDK9 or newer on Macs for Sling API in https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640 <https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640> <https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640 <https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640>>. We can extend to other operating systems if necessary.
>>>>>> On 5. Jan 2019, at 17:23, Konrad Windszus <ko...@gmx.de> wrote:
>>>>>>
>>>>>> Since this does not seem to affect all cases where the IntelliJ null annotations are used I would recommend we enforce building with Java 9+ only for the Sling API part for Mac OS X for now. We can extend to other operating systems if this reliably fails for them as well. WDYT?
>>>>>>
>>>>>>
>>>>>>> On 18. Dec 2018, at 17:35, Konrad Windszus <ko...@gmx.de> wrote:
>>>>>>>
>>>>>>> We can still put it in a dedicated profile which is only active on a Mac.
>>>>>>> I would volunteer to add it to the parent pom since a lot of modules are affected (as the IntelliJ Null annotations are used all over the place).
>>>>>>>
>>>>>>> Konrad
>>>>>>>
>>>>>>>> On 18. Dec 2018, at 17:03, Robert Munteanu <ro...@apache.org> wrote:
>>>>>>>>
>>>>>>>> It's worth noting that it only affects Mac builds so far, so enforcing
>>>>>>>> Java 9 might be a step too far.
>>>>>>>>
>>>>>>>> Robert
>>>>>>>>
>>>>>>>> On Tue, 2018-12-18 at 17:01 +0100, Konrad Windszus wrote:
>>>>>>>>> I think due to that we should enforce building with at least Java 9.
>>>>>>>>> WDYT?
>>>>>>>>>
>>>>>>>>>> On 18. Dec 2018, at 16:54, Konrad Windszus <ko...@gmx.de> wrote:
>>>>>>>>>>
>>>>>>>>>> Thanks a lot for that. Observed that as well but haven't had the
>>>>>>>>>> time to investigate. I fear though that Oracle will no longer fix
>>>>>>>>>> stuff in JDK 8.
>>>>>>>>>> Konrad
>>>>>>>>>>
>>>>>>>>>>> On 18. Dec 2018, at 16:51, Radu Cotescu <ra...@apache.org> wrote:
>>>>>>>>>>>
>>>>>>>>>>> Hi,
>>>>>>>>>>>
>>>>>>>>>>> I’ve submitted yesterday this bug [0] to Oracle. TL;DR: one
>>>>>>>>>>> cannot build the org.apache.sling.api JavaDocs with JDK 8 on
>>>>>>>>>>> macOS. It all started with [1], but it’s obviously a JDK bug.
>>>>>>>>>>>
>>>>>>>>>>> Cheers,
>>>>>>>>>>> Radu
>>>>>>>>>>>
>>>>>>>>>>> [0] -
>>>>>>>>>>> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8215542
>>>>>>>>>>> <https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-
>>>>>>>>>>> 8215542>
>>>>>>>>>>> [1] -
>>>>>>>>>>> https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6
>>>>>>>>>>> <
>>>>>>>>>>> https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>> --
>>>> Carsten Ziegeler
>>>> Adobe Research Switzerland
>>>> cziegeler@apache.org <ma...@apache.org>
>> --
>> Carsten Ziegeler
>> Adobe Research Switzerland
>> cziegeler@apache.org
>
Re: [jdk bug] for those of you on Mac running JDK 1.8
Posted by Konrad Windszus <ko...@gmx.de>.
Thanks for the confirmation. Always activated the profile now in https://github.com/apache/sling-org-apache-sling-api/commit/62da4e295a799f3c784a10f23079ec2224929b1e.
> On 7. Jan 2019, at 11:17, Carsten Ziegeler <cz...@apache.org> wrote:
>
> I get the same error with Windows.
>
>
> Regards
>
> Carsten
>
>
> Konrad Windszus wrote
>> Can anyone check on Windows?
>> Then I would always enable that profile!
>>> On 7. Jan 2019, at 10:13, Carsten Ziegeler <cz...@apache.org> wrote:
>>>
>>> FWIW I get the same error with Ubuntu and Java8
>>>
>>>
>>> Regards
>>>
>>> Carsten
>>>
>>>
>>> Konrad Windszus wrote
>>>> I enforced now JDK9 or newer on Macs for Sling API in https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640 <https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640> <https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640 <https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640>>. We can extend to other operating systems if necessary.
>>>>> On 5. Jan 2019, at 17:23, Konrad Windszus <ko...@gmx.de> wrote:
>>>>>
>>>>> Since this does not seem to affect all cases where the IntelliJ null annotations are used I would recommend we enforce building with Java 9+ only for the Sling API part for Mac OS X for now. We can extend to other operating systems if this reliably fails for them as well. WDYT?
>>>>>
>>>>>
>>>>>> On 18. Dec 2018, at 17:35, Konrad Windszus <ko...@gmx.de> wrote:
>>>>>>
>>>>>> We can still put it in a dedicated profile which is only active on a Mac.
>>>>>> I would volunteer to add it to the parent pom since a lot of modules are affected (as the IntelliJ Null annotations are used all over the place).
>>>>>>
>>>>>> Konrad
>>>>>>
>>>>>>> On 18. Dec 2018, at 17:03, Robert Munteanu <ro...@apache.org> wrote:
>>>>>>>
>>>>>>> It's worth noting that it only affects Mac builds so far, so enforcing
>>>>>>> Java 9 might be a step too far.
>>>>>>>
>>>>>>> Robert
>>>>>>>
>>>>>>> On Tue, 2018-12-18 at 17:01 +0100, Konrad Windszus wrote:
>>>>>>>> I think due to that we should enforce building with at least Java 9.
>>>>>>>> WDYT?
>>>>>>>>
>>>>>>>>> On 18. Dec 2018, at 16:54, Konrad Windszus <ko...@gmx.de> wrote:
>>>>>>>>>
>>>>>>>>> Thanks a lot for that. Observed that as well but haven't had the
>>>>>>>>> time to investigate. I fear though that Oracle will no longer fix
>>>>>>>>> stuff in JDK 8.
>>>>>>>>> Konrad
>>>>>>>>>
>>>>>>>>>> On 18. Dec 2018, at 16:51, Radu Cotescu <ra...@apache.org> wrote:
>>>>>>>>>>
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> I’ve submitted yesterday this bug [0] to Oracle. TL;DR: one
>>>>>>>>>> cannot build the org.apache.sling.api JavaDocs with JDK 8 on
>>>>>>>>>> macOS. It all started with [1], but it’s obviously a JDK bug.
>>>>>>>>>>
>>>>>>>>>> Cheers,
>>>>>>>>>> Radu
>>>>>>>>>>
>>>>>>>>>> [0] -
>>>>>>>>>> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8215542
>>>>>>>>>> <https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-
>>>>>>>>>> 8215542>
>>>>>>>>>> [1] -
>>>>>>>>>> https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6
>>>>>>>>>> <
>>>>>>>>>> https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>> --
>>> Carsten Ziegeler
>>> Adobe Research Switzerland
>>> cziegeler@apache.org <ma...@apache.org>
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziegeler@apache.org
Re: [jdk bug] for those of you on Mac running JDK 1.8
Posted by Carsten Ziegeler <cz...@apache.org>.
I get the same error with Windows.
Regards
Carsten
Konrad Windszus wrote
> Can anyone check on Windows?
> Then I would always enable that profile!
>
>> On 7. Jan 2019, at 10:13, Carsten Ziegeler <cz...@apache.org> wrote:
>>
>> FWIW I get the same error with Ubuntu and Java8
>>
>>
>> Regards
>>
>> Carsten
>>
>>
>> Konrad Windszus wrote
>>> I enforced now JDK9 or newer on Macs for Sling API in https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640 <https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640> <https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640 <https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640>>. We can extend to other operating systems if necessary.
>>>> On 5. Jan 2019, at 17:23, Konrad Windszus <ko...@gmx.de> wrote:
>>>>
>>>> Since this does not seem to affect all cases where the IntelliJ null annotations are used I would recommend we enforce building with Java 9+ only for the Sling API part for Mac OS X for now. We can extend to other operating systems if this reliably fails for them as well. WDYT?
>>>>
>>>>
>>>>> On 18. Dec 2018, at 17:35, Konrad Windszus <ko...@gmx.de> wrote:
>>>>>
>>>>> We can still put it in a dedicated profile which is only active on a Mac.
>>>>> I would volunteer to add it to the parent pom since a lot of modules are affected (as the IntelliJ Null annotations are used all over the place).
>>>>>
>>>>> Konrad
>>>>>
>>>>>> On 18. Dec 2018, at 17:03, Robert Munteanu <ro...@apache.org> wrote:
>>>>>>
>>>>>> It's worth noting that it only affects Mac builds so far, so enforcing
>>>>>> Java 9 might be a step too far.
>>>>>>
>>>>>> Robert
>>>>>>
>>>>>> On Tue, 2018-12-18 at 17:01 +0100, Konrad Windszus wrote:
>>>>>>> I think due to that we should enforce building with at least Java 9.
>>>>>>> WDYT?
>>>>>>>
>>>>>>>> On 18. Dec 2018, at 16:54, Konrad Windszus <ko...@gmx.de> wrote:
>>>>>>>>
>>>>>>>> Thanks a lot for that. Observed that as well but haven't had the
>>>>>>>> time to investigate. I fear though that Oracle will no longer fix
>>>>>>>> stuff in JDK 8.
>>>>>>>> Konrad
>>>>>>>>
>>>>>>>>> On 18. Dec 2018, at 16:51, Radu Cotescu <ra...@apache.org> wrote:
>>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> I’ve submitted yesterday this bug [0] to Oracle. TL;DR: one
>>>>>>>>> cannot build the org.apache.sling.api JavaDocs with JDK 8 on
>>>>>>>>> macOS. It all started with [1], but it’s obviously a JDK bug.
>>>>>>>>>
>>>>>>>>> Cheers,
>>>>>>>>> Radu
>>>>>>>>>
>>>>>>>>> [0] -
>>>>>>>>> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8215542
>>>>>>>>> <https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-
>>>>>>>>> 8215542>
>>>>>>>>> [1] -
>>>>>>>>> https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6
>>>>>>>>> <
>>>>>>>>> https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6
>>>>>>>>>>
>>>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>> --
>> Carsten Ziegeler
>> Adobe Research Switzerland
>> cziegeler@apache.org <ma...@apache.org>
>
--
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org
Re: [jdk bug] for those of you on Mac running JDK 1.8
Posted by Konrad Windszus <ko...@gmx.de>.
Can anyone check on Windows?
Then I would always enable that profile!
> On 7. Jan 2019, at 10:13, Carsten Ziegeler <cz...@apache.org> wrote:
>
> FWIW I get the same error with Ubuntu and Java8
>
>
> Regards
>
> Carsten
>
>
> Konrad Windszus wrote
>> I enforced now JDK9 or newer on Macs for Sling API in https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640 <https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640> <https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640 <https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640>>. We can extend to other operating systems if necessary.
>>> On 5. Jan 2019, at 17:23, Konrad Windszus <ko...@gmx.de> wrote:
>>>
>>> Since this does not seem to affect all cases where the IntelliJ null annotations are used I would recommend we enforce building with Java 9+ only for the Sling API part for Mac OS X for now. We can extend to other operating systems if this reliably fails for them as well. WDYT?
>>>
>>>
>>>> On 18. Dec 2018, at 17:35, Konrad Windszus <ko...@gmx.de> wrote:
>>>>
>>>> We can still put it in a dedicated profile which is only active on a Mac.
>>>> I would volunteer to add it to the parent pom since a lot of modules are affected (as the IntelliJ Null annotations are used all over the place).
>>>>
>>>> Konrad
>>>>
>>>>> On 18. Dec 2018, at 17:03, Robert Munteanu <ro...@apache.org> wrote:
>>>>>
>>>>> It's worth noting that it only affects Mac builds so far, so enforcing
>>>>> Java 9 might be a step too far.
>>>>>
>>>>> Robert
>>>>>
>>>>> On Tue, 2018-12-18 at 17:01 +0100, Konrad Windszus wrote:
>>>>>> I think due to that we should enforce building with at least Java 9.
>>>>>> WDYT?
>>>>>>
>>>>>>> On 18. Dec 2018, at 16:54, Konrad Windszus <ko...@gmx.de> wrote:
>>>>>>>
>>>>>>> Thanks a lot for that. Observed that as well but haven't had the
>>>>>>> time to investigate. I fear though that Oracle will no longer fix
>>>>>>> stuff in JDK 8.
>>>>>>> Konrad
>>>>>>>
>>>>>>>> On 18. Dec 2018, at 16:51, Radu Cotescu <ra...@apache.org> wrote:
>>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> I’ve submitted yesterday this bug [0] to Oracle. TL;DR: one
>>>>>>>> cannot build the org.apache.sling.api JavaDocs with JDK 8 on
>>>>>>>> macOS. It all started with [1], but it’s obviously a JDK bug.
>>>>>>>>
>>>>>>>> Cheers,
>>>>>>>> Radu
>>>>>>>>
>>>>>>>> [0] -
>>>>>>>> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8215542
>>>>>>>> <https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-
>>>>>>>> 8215542>
>>>>>>>> [1] -
>>>>>>>> https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6
>>>>>>>> <
>>>>>>>> https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6
>>>>>>>>>
>>>>>>>>
>>>>>
>>>>>
>>>>
>>>
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziegeler@apache.org <ma...@apache.org>
Re: [jdk bug] for those of you on Mac running JDK 1.8
Posted by Carsten Ziegeler <cz...@apache.org>.
FWIW I get the same error with Ubuntu and Java8
Regards
Carsten
Konrad Windszus wrote
> I enforced now JDK9 or newer on Macs for Sling API in https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640 <https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640>. We can extend to other operating systems if necessary.
>
>> On 5. Jan 2019, at 17:23, Konrad Windszus <ko...@gmx.de> wrote:
>>
>> Since this does not seem to affect all cases where the IntelliJ null annotations are used I would recommend we enforce building with Java 9+ only for the Sling API part for Mac OS X for now. We can extend to other operating systems if this reliably fails for them as well. WDYT?
>>
>>
>>> On 18. Dec 2018, at 17:35, Konrad Windszus <ko...@gmx.de> wrote:
>>>
>>> We can still put it in a dedicated profile which is only active on a Mac.
>>> I would volunteer to add it to the parent pom since a lot of modules are affected (as the IntelliJ Null annotations are used all over the place).
>>>
>>> Konrad
>>>
>>>> On 18. Dec 2018, at 17:03, Robert Munteanu <ro...@apache.org> wrote:
>>>>
>>>> It's worth noting that it only affects Mac builds so far, so enforcing
>>>> Java 9 might be a step too far.
>>>>
>>>> Robert
>>>>
>>>> On Tue, 2018-12-18 at 17:01 +0100, Konrad Windszus wrote:
>>>>> I think due to that we should enforce building with at least Java 9.
>>>>> WDYT?
>>>>>
>>>>>> On 18. Dec 2018, at 16:54, Konrad Windszus <ko...@gmx.de> wrote:
>>>>>>
>>>>>> Thanks a lot for that. Observed that as well but haven't had the
>>>>>> time to investigate. I fear though that Oracle will no longer fix
>>>>>> stuff in JDK 8.
>>>>>> Konrad
>>>>>>
>>>>>>> On 18. Dec 2018, at 16:51, Radu Cotescu <ra...@apache.org> wrote:
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> I’ve submitted yesterday this bug [0] to Oracle. TL;DR: one
>>>>>>> cannot build the org.apache.sling.api JavaDocs with JDK 8 on
>>>>>>> macOS. It all started with [1], but it’s obviously a JDK bug.
>>>>>>>
>>>>>>> Cheers,
>>>>>>> Radu
>>>>>>>
>>>>>>> [0] -
>>>>>>> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8215542
>>>>>>> <https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-
>>>>>>> 8215542>
>>>>>>> [1] -
>>>>>>> https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6
>>>>>>> <
>>>>>>> https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6
>>>>>>>>
>>>>>>>
>>>>
>>>>
>>>
>>
>
>
--
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org
Re: [jdk bug] for those of you on Mac running JDK 1.8
Posted by Konrad Windszus <ko...@gmx.de>.
I enforced now JDK9 or newer on Macs for Sling API in https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640 <https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640>. We can extend to other operating systems if necessary.
> On 5. Jan 2019, at 17:23, Konrad Windszus <ko...@gmx.de> wrote:
>
> Since this does not seem to affect all cases where the IntelliJ null annotations are used I would recommend we enforce building with Java 9+ only for the Sling API part for Mac OS X for now. We can extend to other operating systems if this reliably fails for them as well. WDYT?
>
>
>> On 18. Dec 2018, at 17:35, Konrad Windszus <ko...@gmx.de> wrote:
>>
>> We can still put it in a dedicated profile which is only active on a Mac.
>> I would volunteer to add it to the parent pom since a lot of modules are affected (as the IntelliJ Null annotations are used all over the place).
>>
>> Konrad
>>
>>> On 18. Dec 2018, at 17:03, Robert Munteanu <ro...@apache.org> wrote:
>>>
>>> It's worth noting that it only affects Mac builds so far, so enforcing
>>> Java 9 might be a step too far.
>>>
>>> Robert
>>>
>>> On Tue, 2018-12-18 at 17:01 +0100, Konrad Windszus wrote:
>>>> I think due to that we should enforce building with at least Java 9.
>>>> WDYT?
>>>>
>>>>> On 18. Dec 2018, at 16:54, Konrad Windszus <ko...@gmx.de> wrote:
>>>>>
>>>>> Thanks a lot for that. Observed that as well but haven't had the
>>>>> time to investigate. I fear though that Oracle will no longer fix
>>>>> stuff in JDK 8.
>>>>> Konrad
>>>>>
>>>>>> On 18. Dec 2018, at 16:51, Radu Cotescu <ra...@apache.org> wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I’ve submitted yesterday this bug [0] to Oracle. TL;DR: one
>>>>>> cannot build the org.apache.sling.api JavaDocs with JDK 8 on
>>>>>> macOS. It all started with [1], but it’s obviously a JDK bug.
>>>>>>
>>>>>> Cheers,
>>>>>> Radu
>>>>>>
>>>>>> [0] -
>>>>>> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8215542
>>>>>> <https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-
>>>>>> 8215542>
>>>>>> [1] -
>>>>>> https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6
>>>>>> <
>>>>>> https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6
>>>>>>>
>>>>>>
>>>
>>>
>>
>
Re: [jdk bug] for those of you on Mac running JDK 1.8
Posted by Konrad Windszus <ko...@gmx.de>.
Since this does not seem to affect all cases where the IntelliJ null annotations are used I would recommend we enforce building with Java 9+ only for the Sling API part for Mac OS X for now. We can extend to other operating systems if this reliably fails for them as well. WDYT?
> On 18. Dec 2018, at 17:35, Konrad Windszus <ko...@gmx.de> wrote:
>
> We can still put it in a dedicated profile which is only active on a Mac.
> I would volunteer to add it to the parent pom since a lot of modules are affected (as the IntelliJ Null annotations are used all over the place).
>
> Konrad
>
>> On 18. Dec 2018, at 17:03, Robert Munteanu <ro...@apache.org> wrote:
>>
>> It's worth noting that it only affects Mac builds so far, so enforcing
>> Java 9 might be a step too far.
>>
>> Robert
>>
>> On Tue, 2018-12-18 at 17:01 +0100, Konrad Windszus wrote:
>>> I think due to that we should enforce building with at least Java 9.
>>> WDYT?
>>>
>>>> On 18. Dec 2018, at 16:54, Konrad Windszus <ko...@gmx.de> wrote:
>>>>
>>>> Thanks a lot for that. Observed that as well but haven't had the
>>>> time to investigate. I fear though that Oracle will no longer fix
>>>> stuff in JDK 8.
>>>> Konrad
>>>>
>>>>> On 18. Dec 2018, at 16:51, Radu Cotescu <ra...@apache.org> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> I’ve submitted yesterday this bug [0] to Oracle. TL;DR: one
>>>>> cannot build the org.apache.sling.api JavaDocs with JDK 8 on
>>>>> macOS. It all started with [1], but it’s obviously a JDK bug.
>>>>>
>>>>> Cheers,
>>>>> Radu
>>>>>
>>>>> [0] -
>>>>> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8215542
>>>>> <https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-
>>>>> 8215542>
>>>>> [1] -
>>>>> https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6
>>>>> <
>>>>> https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6
>>>>>>
>>>>>
>>
>>
>
Re: [jdk bug] for those of you on Mac running JDK 1.8
Posted by Julian Reschke <ju...@gmx.de>.
On 2018-12-18 17:35, Konrad Windszus wrote:
> We can still put it in a dedicated profile which is only active on a Mac.
> I would volunteer to add it to the parent pom since a lot of modules are affected (as the IntelliJ Null annotations are used all over the place).
>
> Konrad
I've seen at least one instance of that failure in Oak on Windows as
well, but we just got rid of the annotation in this case (it was a test
class anyway).
Best regards, Julian
Re: [jdk bug] for those of you on Mac running JDK 1.8
Posted by Konrad Windszus <ko...@gmx.de>.
We can still put it in a dedicated profile which is only active on a Mac.
I would volunteer to add it to the parent pom since a lot of modules are affected (as the IntelliJ Null annotations are used all over the place).
Konrad
> On 18. Dec 2018, at 17:03, Robert Munteanu <ro...@apache.org> wrote:
>
> It's worth noting that it only affects Mac builds so far, so enforcing
> Java 9 might be a step too far.
>
> Robert
>
> On Tue, 2018-12-18 at 17:01 +0100, Konrad Windszus wrote:
>> I think due to that we should enforce building with at least Java 9.
>> WDYT?
>>
>>> On 18. Dec 2018, at 16:54, Konrad Windszus <ko...@gmx.de> wrote:
>>>
>>> Thanks a lot for that. Observed that as well but haven't had the
>>> time to investigate. I fear though that Oracle will no longer fix
>>> stuff in JDK 8.
>>> Konrad
>>>
>>>> On 18. Dec 2018, at 16:51, Radu Cotescu <ra...@apache.org> wrote:
>>>>
>>>> Hi,
>>>>
>>>> I’ve submitted yesterday this bug [0] to Oracle. TL;DR: one
>>>> cannot build the org.apache.sling.api JavaDocs with JDK 8 on
>>>> macOS. It all started with [1], but it’s obviously a JDK bug.
>>>>
>>>> Cheers,
>>>> Radu
>>>>
>>>> [0] -
>>>> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8215542
>>>> <https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-
>>>> 8215542>
>>>> [1] -
>>>> https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6
>>>> <
>>>> https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6
>>>>>
>>>>
>
>
Re: [jdk bug] for those of you on Mac running JDK 1.8
Posted by Robert Munteanu <ro...@apache.org>.
It's worth noting that it only affects Mac builds so far, so enforcing
Java 9 might be a step too far.
Robert
On Tue, 2018-12-18 at 17:01 +0100, Konrad Windszus wrote:
> I think due to that we should enforce building with at least Java 9.
> WDYT?
>
> > On 18. Dec 2018, at 16:54, Konrad Windszus <ko...@gmx.de> wrote:
> >
> > Thanks a lot for that. Observed that as well but haven't had the
> > time to investigate. I fear though that Oracle will no longer fix
> > stuff in JDK 8.
> > Konrad
> >
> > > On 18. Dec 2018, at 16:51, Radu Cotescu <ra...@apache.org> wrote:
> > >
> > > Hi,
> > >
> > > I’ve submitted yesterday this bug [0] to Oracle. TL;DR: one
> > > cannot build the org.apache.sling.api JavaDocs with JDK 8 on
> > > macOS. It all started with [1], but it’s obviously a JDK bug.
> > >
> > > Cheers,
> > > Radu
> > >
> > > [0] -
> > > https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8215542
> > > <https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-
> > > 8215542>
> > > [1] -
> > > https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6
> > > <
> > > https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6
> > > >
> > >
Re: [jdk bug] for those of you on Mac running JDK 1.8
Posted by Konrad Windszus <ko...@gmx.de>.
I think due to that we should enforce building with at least Java 9. WDYT?
> On 18. Dec 2018, at 16:54, Konrad Windszus <ko...@gmx.de> wrote:
>
> Thanks a lot for that. Observed that as well but haven't had the time to investigate. I fear though that Oracle will no longer fix stuff in JDK 8.
> Konrad
>
>> On 18. Dec 2018, at 16:51, Radu Cotescu <ra...@apache.org> wrote:
>>
>> Hi,
>>
>> I’ve submitted yesterday this bug [0] to Oracle. TL;DR: one cannot build the org.apache.sling.api JavaDocs with JDK 8 on macOS. It all started with [1], but it’s obviously a JDK bug.
>>
>> Cheers,
>> Radu
>>
>> [0] - https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8215542 <https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8215542>
>> [1] - https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6 <https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6>
>>
>
Re: [jdk bug] for those of you on Mac running JDK 1.8
Posted by Konrad Windszus <ko...@gmx.de>.
Thanks a lot for that. Observed that as well but haven't had the time to investigate. I fear though that Oracle will no longer fix stuff in JDK 8.
Konrad
> On 18. Dec 2018, at 16:51, Radu Cotescu <ra...@apache.org> wrote:
>
> Hi,
>
> I’ve submitted yesterday this bug [0] to Oracle. TL;DR: one cannot build the org.apache.sling.api JavaDocs with JDK 8 on macOS. It all started with [1], but it’s obviously a JDK bug.
>
> Cheers,
> Radu
>
> [0] - https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8215542 <https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8215542>
> [1] - https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6 <https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6>
>
Re: [jdk bug] for those of you on Mac running JDK 1.8
Posted by Radu Cotescu <ra...@apache.org>.
Done. As always, somebody has to review my update and publish it… :)
> On 7 Jan 2019, at 09:03, Konrad Windszus <ko...@gmx.de> wrote:
>
> @Radu: Can you update the JDK bug with that information? I unfortunately cannot comment on that.
Re: [jdk bug] for those of you on Mac running JDK 1.8
Posted by Konrad Windszus <ko...@gmx.de>.
I did some more tests, and the problem is the class https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/spi/resource/provider/ResolveContext.java <https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/spi/resource/provider/ResolveContext.java>.
Only when you remove all annotations along with their import statements (i.e. Nullable, NotNull and ProviderType) javadoc in JDK 8 does no longer fail.
It seems to be related to the fact that this interface is using a type variable.
Only removing the IntelliJ null annotations is not enough here. Not sure why this previously was not a problem with ProviderType only.
@Radu: Can you update the JDK bug with that information? I unfortunately cannot comment on that.
> On 18. Dec 2018, at 16:51, Radu Cotescu <ra...@apache.org> wrote:
>
> Hi,
>
> I’ve submitted yesterday this bug [0] to Oracle. TL;DR: one cannot build the org.apache.sling.api JavaDocs with JDK 8 on macOS. It all started with [1], but it’s obviously a JDK bug.
>
> Cheers,
> Radu
>
> [0] - https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8215542 <https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8215542>
> [1] - https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6 <https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6>
>