You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/09/21 15:12:51 UTC
[GitHub] [pinot] richardstartin opened a new pull request #7456: Fix /version endpoint
richardstartin opened a new pull request #7456:
URL: https://github.com/apache/pinot/pull/7456
## Description
This fixes the manifest scan which drives the /version endpoint which doesn't work on JDK11 (fixes #7449). The problem is that the application class loader is no longer a `URLClassLoader` so the existing approach wouldn't work on JDK9+. Since this logic depends on built jars, this is quite difficult to test, but I verified the fix works by running `HybridQuickstart` with an appropriate class path at the command line:
<img width="1301" alt="Screenshot 2021-09-21 at 16 06 49" src="https://user-images.githubusercontent.com/16439049/134197697-4ab358cd-54c3-4c33-9717-daade64c0a02.png">
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes)
## Release Notes
<!-- If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of the
next release. -->
<!-- If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text.
-->
## Documentation
<!-- If you have introduced a new feature or configuration, please add it to the documentation as well.
See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] richardstartin commented on pull request #7456: Fix /version endpoint
Posted by GitBox <gi...@apache.org>.
richardstartin commented on pull request #7456:
URL: https://github.com/apache/pinot/pull/7456#issuecomment-924139203
As per the description, since this logic depends on built jars, this is quite difficult to test. One option would be to generate a jar file with a MANIFEST.MF in it with "pinot" in the `Implementation-Title` attribute, but this has existed unchanged since 2015 without test coverage and is a non critical component, so may not be worth the bother.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] mayankshriv merged pull request #7456: Fix /version endpoint
Posted by GitBox <gi...@apache.org>.
mayankshriv merged pull request #7456:
URL: https://github.com/apache/pinot/pull/7456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org