You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/11/21 03:47:03 UTC

[GitHub] [hudi] TJX2014 commented on a diff in pull request #7220: [HUDI-5230] Lazy init secondaryView in PriorityBasedFileSystemView

TJX2014 commented on code in PR #7220:
URL: https://github.com/apache/hudi/pull/7220#discussion_r1027556918


##########
hudi-common/src/test/java/org/apache/hudi/common/table/view/TestPriorityBasedFileSystemView.java:
##########
@@ -75,7 +75,8 @@ public class TestPriorityBasedFileSystemView {
 
   @BeforeEach
   public void setUp() {
-    fsView = new PriorityBasedFileSystemView(primary, secondary);
+    fsView = new PriorityBasedFileSystemView(primary, () -> secondary);
+    fsView.getSecondaryView();

Review Comment:
   there are many following cases use secondary directly, if not init here, will cause issues.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org