[GitHub] [activemq-artemis] jbertram edited a comment on issue #2879: ARTEMIS-2535 Add ignorePartialResultException option to LDAPLoginModule

[GitBox <gi...@apache.org>]

jbertram edited a comment on issue #2879: ARTEMIS-2535 Add ignorePartialResultException option to LDAPLoginModule
URL: https://github.com/apache/activemq-artemis/pull/2879#issuecomment-548021166
 
 
   The fix looks fine as far as I can tell, but there needs to be a test along with it to...
   
   1. Verify that a `PartialResultException` is actually thrown an dealt with appropriately.
   2. Mitigate the risk of regressions in the future.
   
   The [commit in the Karaf code-base](https://github.com/apache/karaf/commit/2a1b963d2f958f70f6968f8f6896fe6c95faf656) to deal with the same issue includes a test which may help you write your own here. It doesn't actually use Active Directory which isn't ideal, but I'm not sure how that can be avoided since to my knowledge there's no way to embed and test with AD in a Java project. Take a look at `org.apache.activemq.artemis.core.security.jaas.LDAPLoginModuleTest` and `org.apache.activemq.artemis.tests.integration.security.LDAPSecurityTest` you may want to add your test to one of those or perhaps create a brand new test class patterned after one of them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services