You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/10 02:45:26 UTC

[GitHub] [flink] Myasuka commented on a change in pull request #8668: [FLINK-12784][metrics] Support retention policy for InfluxDB metrics …

Myasuka commented on a change in pull request #8668: [FLINK-12784][metrics] Support retention policy for InfluxDB metrics …
URL: https://github.com/apache/flink/pull/8668#discussion_r291865744
 
 

 ##########
 File path: flink-metrics/flink-metrics-influxdb/src/test/java/org/apache/flink/metrics/influxdb/InfluxdbReporterTest.java
 ##########
 @@ -57,6 +57,7 @@
 	private static final String TEST_INFLUXDB_DB = "test-42";
 	private static final String METRIC_HOSTNAME = "task-mgr-1";
 	private static final String METRIC_TM_ID = "tm-id-123";
+	private String retentionPolicy = "";
 
 Review comment:
   How about using final variable `RETENTION_POLICY` just like above tests?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services