You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by jihoonson <gi...@git.apache.org> on 2015/11/12 07:58:40 UTC
[GitHub] tajo pull request: TAJO-1975: Gathering fine-grained column statis...
GitHub user jihoonson opened a pull request:
https://github.com/apache/tajo/pull/859
TAJO-1975: Gathering fine-grained column statistics for range shuffle
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jihoonson/tajo-2 TAJO-1975
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/859.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #859
----
commit 79ecf906488d6b216ab2f42ed387dde61135c22c
Author: Jihoon Son <ji...@apache.org>
Date: 2015-11-12T05:38:27Z
- Add statistics collection flag for each column
- Rename HashShuffleAppender to HashShuffleAppenderWrapper
commit 809b95f5248aaa4ee9218acfb187cacf83243b1f
Author: Jihoon Son <ji...@apache.org>
Date: 2015-11-12T06:36:27Z
TAJO-1975
commit 225c6e29e06715403afc3e964ab8adb5be073139
Author: Jihoon Son <ji...@apache.org>
Date: 2015-11-12T06:58:17Z
Fix test failure
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1975: Gathering fine-grained column statis...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on a diff in the pull request:
https://github.com/apache/tajo/pull/859#discussion_r44746339
--- Diff: tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/AbstractHBaseAppender.java ---
@@ -53,7 +51,8 @@
protected ColumnMapping columnMapping;
protected TableStatistics stats;
- protected boolean enabledStats;
+ protected boolean tableStatsEnabled;
+ protected BitSet columnStatsEnabled;
--- End diff --
BitSet needs computation cost. How about change to the array?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1975: Gathering fine-grained column statis...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/859
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1975: Gathering fine-grained column statis...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/859#issuecomment-156319375
+1 Looks great to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1975: Gathering fine-grained column statis...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/859#discussion_r44746653
--- Diff: tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/AbstractHBaseAppender.java ---
@@ -53,7 +51,8 @@
protected ColumnMapping columnMapping;
protected TableStatistics stats;
- protected boolean enabledStats;
+ protected boolean tableStatsEnabled;
+ protected BitSet columnStatsEnabled;
--- End diff --
Thanks for your comment. I've changed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---