You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by skonto <gi...@git.apache.org> on 2018/05/19 18:13:30 UTC

[GitHub] spark pull request #20640: [SPARK-19755][Mesos] Blacklist is always active f...

Github user skonto commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20640#discussion_r189441161
  
    --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala ---
    @@ -571,7 +568,7 @@ private[spark] class MesosCoarseGrainedSchedulerBackend(
           cpus + totalCoresAcquired <= maxCores &&
           mem <= offerMem &&
           numExecutors < executorLimit &&
    -      slaves.get(slaveId).map(_.taskFailures).getOrElse(0) < MAX_SLAVE_FAILURES &&
    +      !scheduler.nodeBlacklist().contains(offerHostname) &&
    --- End diff --
    
    Squito sounds reasonable. In the mean time we have to deal with a limitation at the mesos side where the value is hardcoded. So we can move with this incrementally.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org