You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/14 08:56:23 UTC
[GitHub] [flink] victorunique opened a new pull request #17475: [FLINK-24432][rocksdb] RocksIteratorWrapper.seekToLast() logic typo
victorunique opened a new pull request #17475:
URL: https://github.com/apache/flink/pull/17475
## What is the purpose of the change
The RocksIteratorWrapper is a wrapper of RocksIterator to do additional status check for all the methods. However, there's a typo that RocksIteratorWrapper.seekToLast() method calls RocksIterator's seekToFirst(), which is obviously wrong. I guess this issue wasn't found before as it was only referenced in the RocksTransformingIteratorWrapper.seekToLast() method and nowhere else.
## Brief change log
- *Replace the iterator.seekToFirst() to the iterator.seekToLast() in the seekToLast method;*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (no )
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17475: [FLINK-24432][rocksdb] RocksIteratorWrapper.seekToLast() logic typo
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17475:
URL: https://github.com/apache/flink/pull/17475#issuecomment-943157496
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 338bd9b8ae1318875c6311f56f06453f793350e5 (Thu Oct 14 09:00:16 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17475: [FLINK-24432][rocksdb] RocksIteratorWrapper.seekToLast() logic typo
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17475:
URL: https://github.com/apache/flink/pull/17475#issuecomment-943157759
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "338bd9b8ae1318875c6311f56f06453f793350e5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25038",
"triggerID" : "338bd9b8ae1318875c6311f56f06453f793350e5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 338bd9b8ae1318875c6311f56f06453f793350e5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25038)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] victorunique commented on pull request #17475: [FLINK-24432][rocksdb] RocksIteratorWrapper.seekToLast() logic typo
Posted by GitBox <gi...@apache.org>.
victorunique commented on pull request #17475:
URL: https://github.com/apache/flink/pull/17475#issuecomment-943401610
@Myasuka CI works fine. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17475: [FLINK-24432][rocksdb] RocksIteratorWrapper.seekToLast() logic typo
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17475:
URL: https://github.com/apache/flink/pull/17475#issuecomment-943157759
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "338bd9b8ae1318875c6311f56f06453f793350e5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "338bd9b8ae1318875c6311f56f06453f793350e5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 338bd9b8ae1318875c6311f56f06453f793350e5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17475: [FLINK-24432][rocksdb] RocksIteratorWrapper.seekToLast() logic typo
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17475:
URL: https://github.com/apache/flink/pull/17475#issuecomment-943157759
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "338bd9b8ae1318875c6311f56f06453f793350e5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25038",
"triggerID" : "338bd9b8ae1318875c6311f56f06453f793350e5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 338bd9b8ae1318875c6311f56f06453f793350e5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25038)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org