You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/08 07:06:10 UTC
[GitHub] [spark] exmy opened a new pull request #32088: [SPARK-34987][SQL] AQE improve: change shuffle hash join to sort merg…
exmy opened a new pull request #32088:
URL: https://github.com/apache/spark/pull/32088
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
Change shuffle hash join to sort merge join when skewed shuffle hash join exists.
### Why are the changes needed?
AQE currently can only optimize skewed join for sort merge join, it will be better if we can change shuffle hash join to sort merge join when skewed shuffle hash join exists.
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
Adding new test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32088: [SPARK-34987][SQL] AQE improve: change shuffle hash join to sort merg…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32088:
URL: https://github.com/apache/spark/pull/32088#issuecomment-932642201
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #32088: [SPARK-34987][SQL] AQE improve: change shuffle hash join to sort merg…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #32088:
URL: https://github.com/apache/spark/pull/32088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] exmy commented on pull request #32088: [SPARK-34987][SQL] AQE improve: change shuffle hash join to sort merg…
Posted by GitBox <gi...@apache.org>.
exmy commented on pull request #32088:
URL: https://github.com/apache/spark/pull/32088#issuecomment-820071294
@cloud-fan could you help take a look and provide some suggestions? thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] exmy commented on pull request #32088: [SPARK-34987][SQL] AQE improve: change shuffle hash join to sort merg…
Posted by GitBox <gi...@apache.org>.
exmy commented on pull request #32088:
URL: https://github.com/apache/spark/pull/32088#issuecomment-815644906
cc @cloud-fan @JkSelf @maryannxue please take a look, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32088: [SPARK-34987][SQL] AQE improve: change shuffle hash join to sort merg…
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32088:
URL: https://github.com/apache/spark/pull/32088#issuecomment-815512728
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #32088: [SPARK-34987][SQL] AQE improve: change shuffle hash join to sort merg…
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on pull request #32088:
URL: https://github.com/apache/spark/pull/32088#issuecomment-866718769
https://github.com/apache/spark/pull/32328, OptimizeSkewedJoin now support ShuffledHashJoinExec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #32088: [SPARK-34987][SQL] AQE improve: change shuffle hash join to sort merg…
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #32088:
URL: https://github.com/apache/spark/pull/32088#issuecomment-823324591
shuffle hash join is disabled by default. If it's explicitly enabled, I think it's better to keep it and optimize it with the same algorithm optimizing sort merge join.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org