You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Marcel Roelofs (JIRA)" <qp...@incubator.apache.org> on 2010/01/28 13:39:34 UTC
[jira] Created: (QPID-2371) Missing includes for MSVC 2005 compiler
Missing includes for MSVC 2005 compiler
---------------------------------------
Key: QPID-2371
URL: https://issues.apache.org/jira/browse/QPID-2371
Project: Qpid
Issue Type: Improvement
Components: C++ Broker
Affects Versions: 0.6
Environment: MSVC 2005
Reporter: Marcel Roelofs
Priority: Minor
Fix For: 0.6
When compiling the 0.6 release candidate using MSVC 2005 I found some missing header file includes that prevented qpid to compile out of the box. I'll add a patch later.
Also I had to add "/D _WIN32_WINNT=0x0501" to the compiler flags during cmake makefile generation to prevent compile errors in various components, but I've no idea how to add this to the cmake configuration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2371) Missing includes for MSVC 2005
compiler
Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806399#action_12806399 ]
Steve Huston commented on QPID-2371:
------------------------------------
The <winsock2.h> inclusion from the patch is committed at revision: 904563
Marcel, please let us know anything else that needs to get done to fix the MSVC 2005 build.
> Missing includes for MSVC 2005 compiler
> ---------------------------------------
>
> Key: QPID-2371
> URL: https://issues.apache.org/jira/browse/QPID-2371
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: 0.6
> Environment: MSVC 2005
> Reporter: Marcel Roelofs
> Priority: Minor
> Fix For: 0.6
>
> Attachments: msvc2005.patch
>
>
> When compiling the 0.6 release candidate using MSVC 2005 I found some missing header file includes that prevented qpid to compile out of the box. I'll add a patch later.
> Also I had to add "/D _WIN32_WINNT=0x0501" to the compiler flags during cmake makefile generation to prevent compile errors in various components, but I've no idea how to add this to the cmake configuration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2371) Missing includes for MSVC 2005 compiler
Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Huston updated QPID-2371:
-------------------------------
Fix Version/s: (was: 0.6)
0.7
Assignee: Steve Huston
I changed the fix version to 0.7. 0.6 is in the release process and can't be held back for this issue since this is not a regression from 0.5.
> Missing includes for MSVC 2005 compiler
> ---------------------------------------
>
> Key: QPID-2371
> URL: https://issues.apache.org/jira/browse/QPID-2371
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: 0.6
> Environment: MSVC 2005
> Reporter: Marcel Roelofs
> Assignee: Steve Huston
> Priority: Minor
> Fix For: 0.7
>
> Attachments: msvc2005.patch
>
>
> When compiling the 0.6 release candidate using MSVC 2005 I found some missing header file includes that prevented qpid to compile out of the box. I'll add a patch later.
> Also I had to add "/D _WIN32_WINNT=0x0501" to the compiler flags during cmake makefile generation to prevent compile errors in various components, but I've no idea how to add this to the cmake configuration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2371) Missing includes for MSVC 2005
compiler
Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828360#action_12828360 ]
Steve Huston commented on QPID-2371:
------------------------------------
Thanks for checking into this, Marcel. I'd rather not lock this in for every build. Can do please check where this is needed? If it's pervasive, please try this change to cpp/src/CMakeLists.txt instead:
Index: CMakeLists.txt
===================================================================
--- CMakeLists.txt (revision 905160)
+++ CMakeLists.txt (working copy)
@@ -409,6 +409,9 @@
/wd4800
/wd4355
)
+ if (MSVC80)
+ add_definitions(/D "_WIN32_WINNT=0x0501")
+ endif (MSVC80)
endif (MSVC)
set (qpidcommon_platform_SOURCES
> Missing includes for MSVC 2005 compiler
> ---------------------------------------
>
> Key: QPID-2371
> URL: https://issues.apache.org/jira/browse/QPID-2371
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: 0.6
> Environment: MSVC 2005
> Reporter: Marcel Roelofs
> Assignee: Steve Huston
> Priority: Minor
> Fix For: 0.7
>
> Attachments: msvc2005.patch
>
>
> When compiling the 0.6 release candidate using MSVC 2005 I found some missing header file includes that prevented qpid to compile out of the box. I'll add a patch later.
> Also I had to add "/D _WIN32_WINNT=0x0501" to the compiler flags during cmake makefile generation to prevent compile errors in various components, but I've no idea how to add this to the cmake configuration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2371) Missing includes for MSVC 2005
compiler
Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806166#action_12806166 ]
Steve Huston commented on QPID-2371:
------------------------------------
I'm testing the patch adding <winsock2.h> and will commit for 0.7 if all is well with the vc9 build.
I'm not going to apply the patch for ResilientConnection.cpp - that is the subject of another jira, QPID-1982 and should be resolved in a more portable manner. For now you can ignore that piece of Qpid.
Please update this jira if you learn more about the _WIN32_WINNT requirement. I test the build daily on VC9 (Win XP and XP-64) without the need for this.
> Missing includes for MSVC 2005 compiler
> ---------------------------------------
>
> Key: QPID-2371
> URL: https://issues.apache.org/jira/browse/QPID-2371
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: 0.6
> Environment: MSVC 2005
> Reporter: Marcel Roelofs
> Priority: Minor
> Fix For: 0.6
>
> Attachments: msvc2005.patch
>
>
> When compiling the 0.6 release candidate using MSVC 2005 I found some missing header file includes that prevented qpid to compile out of the box. I'll add a patch later.
> Also I had to add "/D _WIN32_WINNT=0x0501" to the compiler flags during cmake makefile generation to prevent compile errors in various components, but I've no idea how to add this to the cmake configuration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2371) Missing includes for MSVC 2005 compiler
Posted by "Marcel Roelofs (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Roelofs updated QPID-2371:
---------------------------------
Attachment: msvc2005.patch
Missing includes for MSVC 2005 compilation
> Missing includes for MSVC 2005 compiler
> ---------------------------------------
>
> Key: QPID-2371
> URL: https://issues.apache.org/jira/browse/QPID-2371
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: 0.6
> Environment: MSVC 2005
> Reporter: Marcel Roelofs
> Priority: Minor
> Fix For: 0.6
>
> Attachments: msvc2005.patch
>
>
> When compiling the 0.6 release candidate using MSVC 2005 I found some missing header file includes that prevented qpid to compile out of the box. I'll add a patch later.
> Also I had to add "/D _WIN32_WINNT=0x0501" to the compiler flags during cmake makefile generation to prevent compile errors in various components, but I've no idea how to add this to the cmake configuration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2371) Missing includes for MSVC 2005
compiler
Posted by "Marcel Roelofs (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828785#action_12828785 ]
Marcel Roelofs commented on QPID-2371:
--------------------------------------
It's not really pervasive, it's needed to get mssql_store and qpidxarm compiled properly. The first component has its own cmakefile where you could add the extra define, but the latter is generated via the cmakefile to which I suggested the change (for that particular reason).
Your change works fine as well, it's just my non-fluency in cmake that made me come up with my less sophisticated solution.
With the exception of the ResilientConnection.cpp compilation (that was subject of QPID-1982), it seems we're there now to get everything to compile and link properly using VC8. In case you're interested, in ResilientConnection.cpp the problem was the write function not being declared anywhere. If that's relevant information for QPID-1982, I would add it as a comment there, and close this jira.
> Missing includes for MSVC 2005 compiler
> ---------------------------------------
>
> Key: QPID-2371
> URL: https://issues.apache.org/jira/browse/QPID-2371
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: 0.6
> Environment: MSVC 2005
> Reporter: Marcel Roelofs
> Assignee: Steve Huston
> Priority: Minor
> Fix For: 0.7
>
> Attachments: msvc2005.patch
>
>
> When compiling the 0.6 release candidate using MSVC 2005 I found some missing header file includes that prevented qpid to compile out of the box. I'll add a patch later.
> Also I had to add "/D _WIN32_WINNT=0x0501" to the compiler flags during cmake makefile generation to prevent compile errors in various components, but I've no idea how to add this to the cmake configuration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2371) Missing includes for MSVC 2005
compiler
Posted by "Marcel Roelofs (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828105#action_12828105 ]
Marcel Roelofs commented on QPID-2371:
--------------------------------------
Steve, everything compiles out of the box with the patch to the cmakefile below. The extra define specifies that the compiler targets Windows XP and Windows Server 2003; it's necessary to pull some extra declarations into the Windows header files that are needed to compile qpid. Apparently this (or better) is already the default for VC9 but not for VC8. If the default for VC9 is higher than I guess taking the VC9 default value won't hurt either.
--- cpp/src/CMakeLists.txt (revision 904026)
+++ cpp/src/CMakeLists.txt (working copy)
@@ -404,6 +404,7 @@
/D "NOMINMAX"
/D "WIN32_LEAN_AND_MEAN"
/D "_SCL_SECURE_NO_WARNINGS"
+ /D _WIN32_WINNT=0x0501
/wd4244
/wd4800
/wd4355
> Missing includes for MSVC 2005 compiler
> ---------------------------------------
>
> Key: QPID-2371
> URL: https://issues.apache.org/jira/browse/QPID-2371
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: 0.6
> Environment: MSVC 2005
> Reporter: Marcel Roelofs
> Assignee: Steve Huston
> Priority: Minor
> Fix For: 0.7
>
> Attachments: msvc2005.patch
>
>
> When compiling the 0.6 release candidate using MSVC 2005 I found some missing header file includes that prevented qpid to compile out of the box. I'll add a patch later.
> Also I had to add "/D _WIN32_WINNT=0x0501" to the compiler flags during cmake makefile generation to prevent compile errors in various components, but I've no idea how to add this to the cmake configuration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Resolved: (QPID-2371) Missing includes for MSVC 2005
compiler
Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Huston resolved QPID-2371.
--------------------------------
Resolution: Fixed
Fixed on trunk r907733.
> Missing includes for MSVC 2005 compiler
> ---------------------------------------
>
> Key: QPID-2371
> URL: https://issues.apache.org/jira/browse/QPID-2371
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: 0.6
> Environment: MSVC 2005
> Reporter: Marcel Roelofs
> Assignee: Steve Huston
> Priority: Minor
> Fix For: 0.7
>
> Attachments: msvc2005.patch
>
>
> When compiling the 0.6 release candidate using MSVC 2005 I found some missing header file includes that prevented qpid to compile out of the box. I'll add a patch later.
> Also I had to add "/D _WIN32_WINNT=0x0501" to the compiler flags during cmake makefile generation to prevent compile errors in various components, but I've no idea how to add this to the cmake configuration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org