You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/04/14 20:30:18 UTC
[kudu-CR] [rpc] introduced Messenger::reset authn token() method
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6639
Change subject: [rpc] introduced Messenger::reset_authn_token() method
......................................................................
[rpc] introduced Messenger::reset_authn_token() method
Introduced a method to reset authn token in the messenger. It's needed
to clear expired authn token from the context to be able to re-connect
to a cluster using other authentication methods other than authn token.
Change-Id: I3877db4747f977ed1a0b8a2c4f78ca77de7aca93
---
M src/kudu/rpc/messenger.h
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/6639/1
--
To view, visit http://gerrit.cloudera.org:8080/6639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3877db4747f977ed1a0b8a2c4f78ca77de7aca93
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [rpc] introduced Messenger::reset authn token() method
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [rpc] introduced Messenger::reset_authn_token() method
......................................................................
Patch Set 2:
hrm, not a fan of this kind of standalone patch that adds a function with no call sites/tests. Can this be merged into whatever patch uses it?
--
To view, visit http://gerrit.cloudera.org:8080/6639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3877db4747f977ed1a0b8a2c4f78ca77de7aca93
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [rpc] introduced Messenger::reset authn token() method
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [rpc] introduced Messenger::reset_authn_token() method
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6639/1/src/kudu/rpc/messenger.h
File src/kudu/rpc/messenger.h:
Line 223: std::lock_guard<simple_spinlock> l(authn_token_lock_);
> This should be taking the authn_token_lock_
uh-oh, somehow I missed that crucial point.
Done.
--
To view, visit http://gerrit.cloudera.org:8080/6639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3877db4747f977ed1a0b8a2c4f78ca77de7aca93
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [rpc] introduced Messenger::reset authn token() method
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [rpc] introduced Messenger::reset_authn_token() method
......................................................................
Patch Set 2:
Yea, I think if this had some complexity and its own unit test, would be nice to be separate, but here it's basically a simple setter.
--
To view, visit http://gerrit.cloudera.org:8080/6639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3877db4747f977ed1a0b8a2c4f78ca77de7aca93
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [rpc] introduced Messenger::reset authn token() method
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6639
to look at the new patch set (#2).
Change subject: [rpc] introduced Messenger::reset_authn_token() method
......................................................................
[rpc] introduced Messenger::reset_authn_token() method
Introduced a method to reset authn token in the messenger. It's needed
to clear expired authn token from the context to be able to re-connect
to a cluster using other authentication methods other than authn token.
Change-Id: I3877db4747f977ed1a0b8a2c4f78ca77de7aca93
---
M src/kudu/rpc/messenger.h
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/6639/2
--
To view, visit http://gerrit.cloudera.org:8080/6639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3877db4747f977ed1a0b8a2c4f78ca77de7aca93
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [rpc] introduced Messenger::reset authn token() method
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [rpc] introduced Messenger::reset_authn_token() method
......................................................................
Patch Set 2:
> hrm, not a fan of this kind of standalone patch that adds a
> function with no call sites/tests. Can this be merged into whatever
> patch uses it?
Yes, there is a patch it can be part of: https://gerrit.cloudera.org/#/c/6648/
I thought it might be too much other code besides this simple patch, so I decided to separate it out.
OK, then I'll merge it with 6648
--
To view, visit http://gerrit.cloudera.org:8080/6639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3877db4747f977ed1a0b8a2c4f78ca77de7aca93
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [rpc] introduced Messenger::reset authn token() method
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [rpc] introduced Messenger::reset_authn_token() method
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6639/1/src/kudu/rpc/messenger.h
File src/kudu/rpc/messenger.h:
Line 223: authn_token_.reset();
This should be taking the authn_token_lock_
--
To view, visit http://gerrit.cloudera.org:8080/6639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3877db4747f977ed1a0b8a2c4f78ca77de7aca93
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [rpc] introduced Messenger::reset authn token() method
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has abandoned this change.
Change subject: [rpc] introduced Messenger::reset_authn_token() method
......................................................................
Abandoned
Integrated into https://gerrit.cloudera.org/#/c/6648/
--
To view, visit http://gerrit.cloudera.org:8080/6639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I3877db4747f977ed1a0b8a2c4f78ca77de7aca93
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>