You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Melvii Ts (JIRA)" <ji...@apache.org> on 2014/01/19 11:54:19 UTC

[jira] [Commented] (THRIFT-1525) Serialization / Deterialization of oversized i32 problematic in TCompactProtocol

    [ https://issues.apache.org/jira/browse/THRIFT-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875844#comment-13875844 ] 

Melvii Ts commented on THRIFT-1525:
-----------------------------------

I suggest raising a ValueError instead.

> Serialization / Deterialization of oversized i32 problematic in TCompactProtocol
> --------------------------------------------------------------------------------
>
>                 Key: THRIFT-1525
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1525
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Library
>    Affects Versions: 0.8
>            Reporter: Ted Schundler
>            Priority: Minor
>         Attachments: THRIFT-1525.compactproto_rangechecks_v1.patch
>
>
> Serialization of integers outside of the range handled by i32 numbers happens without any errors raised.
> Deserialization yields unexpected results - for example 3000000000 (outside the range of i32) will be deserialized as -3000000000 (also outside the range of i32, and not the same as simply casting the unsigned int as signed)



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)