You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Marton Greber (Code Review)" <ge...@cloudera.org> on 2026/03/31 12:29:50 UTC
[kudu-CR] Fix misleading Javadoc for writer.maxBufferSize
Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24157
Change subject: Fix misleading Javadoc for writer.maxBufferSize
......................................................................
Fix misleading Javadoc for writer.maxBufferSize
The Javadoc for writer.maxBufferSize incorrectly described it as
"maximum size in bytes of the client-side write buffer". It actually
maps to KuduSession's mutationBufferMaxOps, which is a count of
buffered mutation operations, not a byte size.
The confusion likely stems from the parameter name in the Flink
connector (KuduWriterConfig.maxBufferSize), which implies a byte
quantity, while the connector's own source comment clarifies:
"Reference from AsyncKuduSession mutationBufferMaxOps 1000."
Change-Id: I2e79b888ecc4bd0ef815aeadec9003027b7d6b3a
---
M java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationConfigParser.java
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/24157/1
--
To view, visit http://gerrit.cloudera.org:8080/24157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e79b888ecc4bd0ef815aeadec9003027b7d6b3a
Gerrit-Change-Number: 24157
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
[kudu-CR] Fix misleading Javadoc for writer.maxBufferSize
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24157 )
Change subject: Fix misleading Javadoc for writer.maxBufferSize
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/24157/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/24157/1//COMMIT_MSG@14
PS1, Line 14: The confusion likely stems from the parameter name in the Flink
: connector (KuduWriterConfig.maxBufferSize), which implies a byte
: quantity, while the connector's own source comment clarifies:
: "Reference from AsyncKuduSession mutationBufferMaxOps 1000."
> The naming confusion originates from flink-connector-kudu's KuduWriterConfi
Sounds good to me.
Thank you for filing a jira to address this.
--
To view, visit http://gerrit.cloudera.org:8080/24157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e79b888ecc4bd0ef815aeadec9003027b7d6b3a
Gerrit-Change-Number: 24157
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Apr 2026 10:37:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] Fix misleading Javadoc for writer.maxBufferSize
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24157 )
Change subject: Fix misleading Javadoc for writer.maxBufferSize
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/2438/
--
To view, visit http://gerrit.cloudera.org:8080/24157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e79b888ecc4bd0ef815aeadec9003027b7d6b3a
Gerrit-Change-Number: 24157
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 31 Mar 2026 12:29:59 +0000
Gerrit-HasComments: No
[kudu-CR] Fix misleading Javadoc for writer.maxBufferSize
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24157 )
Change subject: Fix misleading Javadoc for writer.maxBufferSize
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/24157/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/24157/1//COMMIT_MSG@14
PS1, Line 14: The confusion likely stems from the parameter name in the Flink
: connector (KuduWriterConfig.maxBufferSize), which implies a byte
: quantity, while the connector's own source comment clarifies:
: "Reference from AsyncKuduSession mutationBufferMaxOps 1000."
> Why not change the name everywhere so that it is no more confusing? Even wi
The naming confusion originates from flink-connector-kudu's KuduWriterConfig.maxBufferSize, which this code calls directly. Renaming only the CLI parameter in the replication layer would create an asymmetry with the underlying API. Filed FLINK-39374 to rename the field at the source; the replication code can follow up in a subsequent patch. In the meantime, the test value has been corrected from 5242880 (clearly written assuming bytes) to a realistic operation count.
http://gerrit.cloudera.org:8080/#/c/24157/1/java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationConfigParser.java
File java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationConfigParser.java:
http://gerrit.cloudera.org:8080/#/c/24157/1/java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationConfigParser.java@155
PS1, Line 155: <li>{@code writer.maxBufferSize} (optional) – maximum number of operations buffered in the
: * Kudu write session (maps to {@code mutationBufferMaxOps})</li>
> Do you think TestReplicationConfigParser.java also needs to change here:
Although this is only parameter test, changed to a sensible value.
--
To view, visit http://gerrit.cloudera.org:8080/24157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e79b888ecc4bd0ef815aeadec9003027b7d6b3a
Gerrit-Change-Number: 24157
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Apr 2026 08:46:39 +0000
Gerrit-HasComments: Yes
[kudu-CR] Fix misleading Javadoc for writer.maxBufferSize
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24157 )
Change subject: Fix misleading Javadoc for writer.maxBufferSize
......................................................................
Patch Set 1: Verified+1
Build Successful
http://jenkins.kudu.apache.org/job/pre_commit/2438/ : SUCCESS
--
To view, visit http://gerrit.cloudera.org:8080/24157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e79b888ecc4bd0ef815aeadec9003027b7d6b3a
Gerrit-Change-Number: 24157
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Mar 2026 13:32:43 +0000
Gerrit-HasComments: No
[kudu-CR] Fix misleading Javadoc for writer.maxBufferSize
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24157 )
Change subject: Fix misleading Javadoc for writer.maxBufferSize
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/24157/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/24157/1//COMMIT_MSG@14
PS1, Line 14: The confusion likely stems from the parameter name in the Flink
: connector (KuduWriterConfig.maxBufferSize), which implies a byte
: quantity, while the connector's own source comment clarifies:
: "Reference from AsyncKuduSession mutationBufferMaxOps 1000."
Why not change the name everywhere so that it is no more confusing? Even with fixed comment, variable name may still lead to confusion.
http://gerrit.cloudera.org:8080/#/c/24157/1/java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationConfigParser.java
File java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationConfigParser.java:
http://gerrit.cloudera.org:8080/#/c/24157/1/java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationConfigParser.java@155
PS1, Line 155: <li>{@code writer.maxBufferSize} (optional) – maximum number of operations buffered in the
: * Kudu write session (maps to {@code mutationBufferMaxOps})</li>
Do you think TestReplicationConfigParser.java also needs to change here:
++
229 public void testWriterConfigAllParamsPresent() {
230 String[] args = {
231 "--writer.flushMode", "AUTO_FLUSH_SYNC",
232 "--writer.operationTimeout", "60000",
233 "--writer.maxBufferSize", "5242880", >>>>
234 "--writer.flushInterval", "2000",
235 "--writer.ignoreNotFound", "true",
236 "--writer.ignoreDuplicate", "true"
237 };
+++
--
To view, visit http://gerrit.cloudera.org:8080/24157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e79b888ecc4bd0ef815aeadec9003027b7d6b3a
Gerrit-Change-Number: 24157
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Apr 2026 06:02:49 +0000
Gerrit-HasComments: Yes
[kudu-CR] Fix misleading Javadoc for writer.maxBufferSize
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Ashwani Raina, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24157
to look at the new patch set (#2).
Change subject: Fix misleading Javadoc for writer.maxBufferSize
......................................................................
Fix misleading Javadoc for writer.maxBufferSize
The Javadoc for writer.maxBufferSize incorrectly described it as
"maximum size in bytes of the client-side write buffer". It actually
maps to KuduSession's mutationBufferMaxOps, which is a count of
buffered mutation operations, not a byte size.
The confusion likely stems from the parameter name in the Flink
connector (KuduWriterConfig.maxBufferSize), which implies a byte
quantity, while the connector's own source comment clarifies:
"Reference from AsyncKuduSession mutationBufferMaxOps 1000."
Change-Id: I2e79b888ecc4bd0ef815aeadec9003027b7d6b3a
---
M java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationConfigParser.java
M java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java
2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/24157/2
--
To view, visit http://gerrit.cloudera.org:8080/24157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2e79b888ecc4bd0ef815aeadec9003027b7d6b3a
Gerrit-Change-Number: 24157
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] Fix misleading Javadoc for writer.maxBufferSize
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has removed a vote on this change.
Change subject: Fix misleading Javadoc for writer.maxBufferSize
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/24157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I2e79b888ecc4bd0ef815aeadec9003027b7d6b3a
Gerrit-Change-Number: 24157
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] Fix misleading Javadoc for writer.maxBufferSize
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/24157 )
Change subject: Fix misleading Javadoc for writer.maxBufferSize
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e79b888ecc4bd0ef815aeadec9003027b7d6b3a
Gerrit-Change-Number: 24157
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Apr 2026 08:43:40 +0000
Gerrit-HasComments: No
[kudu-CR] Fix misleading Javadoc for writer.maxBufferSize
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24157 )
Change subject: Fix misleading Javadoc for writer.maxBufferSize
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/2441/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/24157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e79b888ecc4bd0ef815aeadec9003027b7d6b3a
Gerrit-Change-Number: 24157
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Apr 2026 09:36:42 +0000
Gerrit-HasComments: No
[kudu-CR] Fix misleading Javadoc for writer.maxBufferSize
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/24157 )
Change subject: Fix misleading Javadoc for writer.maxBufferSize
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e79b888ecc4bd0ef815aeadec9003027b7d6b3a
Gerrit-Change-Number: 24157
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Mar 2026 12:42:41 +0000
Gerrit-HasComments: No
[kudu-CR] Fix misleading Javadoc for writer.maxBufferSize
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24157 )
Change subject: Fix misleading Javadoc for writer.maxBufferSize
......................................................................
Fix misleading Javadoc for writer.maxBufferSize
The Javadoc for writer.maxBufferSize incorrectly described it as
"maximum size in bytes of the client-side write buffer". It actually
maps to KuduSession's mutationBufferMaxOps, which is a count of
buffered mutation operations, not a byte size.
The confusion likely stems from the parameter name in the Flink
connector (KuduWriterConfig.maxBufferSize), which implies a byte
quantity, while the connector's own source comment clarifies:
"Reference from AsyncKuduSession mutationBufferMaxOps 1000."
Change-Id: I2e79b888ecc4bd0ef815aeadec9003027b7d6b3a
Reviewed-on: http://gerrit.cloudera.org:8080/24157
Reviewed-by: Ashwani Raina <ar...@gmail.com>
Tested-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
---
M java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationConfigParser.java
M java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Ashwani Raina: Looks good to me, but someone else must approve
Marton Greber: Verified
Zoltan Chovan: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/24157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e79b888ecc4bd0ef815aeadec9003027b7d6b3a
Gerrit-Change-Number: 24157
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] Fix misleading Javadoc for writer.maxBufferSize
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24157 )
Change subject: Fix misleading Javadoc for writer.maxBufferSize
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/2441/
--
To view, visit http://gerrit.cloudera.org:8080/24157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e79b888ecc4bd0ef815aeadec9003027b7d6b3a
Gerrit-Change-Number: 24157
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Apr 2026 08:44:58 +0000
Gerrit-HasComments: No
[kudu-CR] Fix misleading Javadoc for writer.maxBufferSize
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24157 )
Change subject: Fix misleading Javadoc for writer.maxBufferSize
......................................................................
Patch Set 2: Verified+1
unrelated test failure:
tsan: org.apache.kudu.spark.kudu.DefaultSourceTest
--
To view, visit http://gerrit.cloudera.org:8080/24157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e79b888ecc4bd0ef815aeadec9003027b7d6b3a
Gerrit-Change-Number: 24157
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Apr 2026 05:55:46 +0000
Gerrit-HasComments: No