You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/17 09:13:13 UTC
[GitHub] [pulsar] eolivelli commented on a change in pull request #10601: Fix getting partition metadata of a nonexistent topic returns 0
eolivelli commented on a change in pull request #10601:
URL: https://github.com/apache/pulsar/pull/10601#discussion_r633360745
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest.java
##########
@@ -873,6 +872,13 @@ public void persistentTopics(String topicName) throws Exception {
public void partitionedTopics(String topicName) throws Exception {
assertEquals(admin.topics().getPartitionedTopicList("prop-xyz/ns1"), Lists.newArrayList());
final String partitionedTopicName = "persistent://prop-xyz/ns1/" + topicName;
+
+ try {
+ admin.topics().getPartitionedTopicMetadata(partitionedTopicName);
+ fail("getPartitionedTopicMetadata of " + partitionedTopicName + " should not succeed");
+ } catch (NotFoundException ignored) {
Review comment:
nit: rename `ignored` to `expected`
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest.java
##########
@@ -882,8 +888,11 @@ public void partitionedTopics(String topicName) throws Exception {
List<String> topics = admin.topics().getList("prop-xyz/ns1");
assertEquals(topics.size(), 4);
- assertEquals(admin.topics().getPartitionedTopicMetadata("persistent://prop-xyz/ns1/ds2").partitions,
- 0);
+ try {
+ admin.topics().getPartitionedTopicMetadata("persistent://prop-xyz/ns1/ds2");
+ fail("getPartitionedTopicMetadata of persistent://prop-xyz/ns1/ds2 should not succeed");
+ } catch (NotFoundException ignored) {
Review comment:
nit: rename `ignored` to `expected`
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest.java
##########
@@ -1003,7 +1012,11 @@ public void partitionedTopics(String topicName) throws Exception {
admin.topics().deletePartitionedTopic(partitionedTopicName);
- assertEquals(admin.topics().getPartitionedTopicMetadata(partitionedTopicName).partitions, 0);
+ try {
+ admin.topics().getPartitionedTopicMetadata(partitionedTopicName);
+ fail("getPartitionedTopicMetadata of " + partitionedTopicName + " should not succeed");
+ } catch (NotFoundException ignored) {
Review comment:
nit: rename `ignored` to `expected`
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v1/V1_AdminApiTest.java
##########
@@ -908,7 +910,11 @@ public void partitionedTopics(String topicName) throws Exception {
admin.topics().deletePartitionedTopic(partitionedTopicName);
- assertEquals(admin.topics().getPartitionedTopicMetadata(partitionedTopicName).partitions, 0);
+ try {
+ admin.topics().getPartitionedTopicMetadata(partitionedTopicName);
+ fail("getPartitionedTopicMetadata of " + partitionedTopicName + " should not succeed");
+ } catch (NotFoundException ignored) {
Review comment:
nit: rename `ignored` to `expected`
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java
##########
@@ -154,8 +154,10 @@ public void testGetPartitionedMetadataWithoutCheckAllowAutoCreation() throws Exc
pulsar.getConfiguration().setDefaultNumPartitions(3);
final String topicString = "persistent://prop/ns-abc/test-topic-3";
- int partitions = admin.topics().getPartitionedTopicMetadata(topicString).partitions;
- assertEquals(partitions, 0);
+ try {
+ admin.topics().getPartitionedTopicMetadata(topicString);
+ } catch (PulsarAdminException.NotFoundException ignored) {
Review comment:
nit: rename `ignored` to `expected`
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v1/V1_AdminApiTest.java
##########
@@ -792,9 +792,11 @@ public void partitionedTopics(String topicName) throws Exception {
List<String> topics = admin.topics().getList("prop-xyz/use/ns1");
assertEquals(topics.size(), 4);
- assertEquals(
- admin.topics().getPartitionedTopicMetadata("persistent://prop-xyz/use/ns1/ds2").partitions,
- 0);
+ try {
+ admin.topics().getPartitionedTopicMetadata("persistent://prop-xyz/use/ns1/ds2");
+ fail("getPartitionedTopicMetadata of persistent://prop-xyz/use/ns1/ds2 should not succeed");
+ } catch (NotFoundException ignored) {
Review comment:
nit: rename `ignored` to `expected`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org