[GitHub] [incubator-superset] zuzana-vej commented on issue #11662: Chart can be added to Dashboard by Non-admin

[GitBox <gi...@apache.org>]

zuzana-vej commented on issue #11662:
URL: https://github.com/apache/incubator-superset/issues/11662#issuecomment-730014498


   I couldn't see issue you are talking about in current behavior (on master). Here are the scenarios and results.
   
   1. If you are dashboard owner - you can add chart from chart explore to dashboard directly. This works.
   2. If you are NOT dashboard owner but are CREATOR of the dashboard (for example I created a dashboard, and then I asked an admin to remove me as owner, but I was still the creator of that dashboard) - I could still edit the dashboard (when on dashboard) and add charts, but I wasn't able to see this dashboard in the dropdown on chart explore, so I actually couldn't add chart directly from chart explore. --> assuming creator always keeps edit rights, this potentially might be a small bug, that creator can't add from chart explore directly (but simple workaround to add form dashboard)
   3. And if I was not owner or creator, I couldn't edit dashboard and couldn't add chart into dashboard from chart explore. This is expected.
   
   Unrelated thing I noticed, is that user (not admin) who is dashboard owner is not able remove themselves from dashboard owners (even if there are additional owners). This could be a bug.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org