[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #3877: [Improve][Connector-V2][Redis] RedisSource support scan operation

[GitBox <gi...@apache.org>]

EricJoy2048 commented on code in PR #3877:
URL: https://github.com/apache/incubator-seatunnel/pull/3877#discussion_r1062600816


##########
seatunnel-connectors-v2/connector-redis/src/main/java/org/apache/seatunnel/connectors/seatunnel/redis/config/RedisConfig.java:
##########
@@ -60,7 +61,19 @@ public enum HashKeyParseMode {
         Options.key("keys")
             .stringType()
             .noDefaultValue()
-            .withDescription("keys pattern, redis source connector support fuzzy key matching, user needs to ensure that the matched keys are the same type");
+            .withDescription("keys pattern, redis source connector support fuzzy key matching, if keys_type_check is false, user needs to ensure that the matched keys are the same type");
+
+    public static final Option<Boolean> KEY_TYPE_CHECK =

Review Comment:
   Please update the document and add change log about this pr.



##########
seatunnel-connectors-v2/connector-redis/src/main/java/org/apache/seatunnel/connectors/seatunnel/redis/config/RedisConfig.java:
##########
@@ -60,7 +61,19 @@ public enum HashKeyParseMode {
         Options.key("keys")
             .stringType()
             .noDefaultValue()
-            .withDescription("keys pattern, redis source connector support fuzzy key matching, user needs to ensure that the matched keys are the same type");
+            .withDescription("keys pattern, redis source connector support fuzzy key matching, if keys_type_check is false, user needs to ensure that the matched keys are the same type");
+
+    public static final Option<Boolean> KEY_TYPE_CHECK =

Review Comment:
   You need update the RedisSourceFactory too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org