You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2019/07/03 14:07:45 UTC

[GitHub] [tinkerpop] spmallette commented on issue #1042: TINKERPOP-2133 Implement index lookup for Text predicates

spmallette commented on issue #1042: TINKERPOP-2133 Implement index lookup for Text predicates
URL: https://github.com/apache/tinkerpop/pull/1042#issuecomment-508108697
 
 
   #1149 did fix the build problems. I've created this branch from master:
   
   https://github.com/apache/tinkerpop/tree/TINKERPOP-2133
   
   and merged this PR there. That leaves:
   
   1. checking into MultiMetaNeo4jTrait and modifying that as needed
   1. checking for tests that validate these changes somehow? There are `TextP` tests in the `HastTest` suite of `gremlin-test` but does anything in neo4j need to be configured for the string matching to work?
   1. needs upgrade docs.
   
   closing this now and will comment in the JIRA issue as to where things were left.  thanks for getting this issue this far along @skorikov 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services